Skip to content

Commit 0608a44

Browse files
committed
Refactored flash messages
1 parent 1cb6da1 commit 0608a44

7 files changed

Lines changed: 45 additions & 22 deletions

File tree

src/LIN3S/AdminBundle/Resources/private/scss/app.scss

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,12 @@
1111
@import 'base/reset';
1212
@import 'base/common';
1313

14-
@import '../node_modules/lin3s-front-foundation/src/scss/atoms/_parsley-form-error.scss';
15-
1614
@import 'components/button';
1715
@import 'components/confirm-dialog';
18-
@import 'components/flash';
16+
@import 'components/flash-message';
1917
@import 'components/form';
2018
@import 'components/form-collection';
19+
@import 'components/form-error';
2120
@import 'components/filter';
2221
@import 'components/header';
2322
@import 'components/layout';

src/LIN3S/AdminBundle/Resources/private/scss/components/_flash.scss renamed to src/LIN3S/AdminBundle/Resources/private/scss/components/_flash-message.scss

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@
1111
@import '../variables/typography';
1212
@import '../helpers/panel';
1313

14-
$flash-success-color: $color-chateau-green !default;
15-
$flash-error-color: $color-thunderbird !default;
14+
$flash-message-success-color: $color-chateau-green !default;
15+
$flash-message-error-color: $color-thunderbird !default;
1616

17-
.flash {
17+
.flash-message {
1818
@extend %panel;
1919
margin-bottom: 30px;
2020
padding: 10px 15px;
2121
}
2222

23-
.flash--success {
24-
border-left: 3px solid $flash-success-color;
23+
.flash-message--success {
24+
border-left: 3px solid $flash-message-success-color;
2525
}
2626

27-
.flash--error {
28-
border-left: 3px solid $flash-error-color;
27+
.flash-message--error {
28+
border-left: 3px solid $flash-message-error-color;
2929
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// This file is part of the Admin Bundle.
2+
//
3+
// Copyright (c) 2015-present LIN3S <info@lin3s.com>
4+
//
5+
// For the full copyright and license information, please view the LICENSE
6+
// file that was distributed with this source code.
7+
//
8+
// @author Beñat Espiña <benatespina@gmail.com>
9+
10+
@import '../../node_modules/lin3s-front-foundation/src/scss/atoms/_parsley-form-error.scss';
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<div class="flash-message {% if type is defined and type == 'error' %}flash-message--error{% else %}flash-message--success{% endif %}">
2+
{{ flash_message }}
3+
</div>
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{% macro success(message) %}
2+
{% include 'Lin3sAdminBundle:components:flash_message.html.twig' with {
3+
flash_message: message
4+
} %}
5+
{% endmacro %}
6+
7+
{% macro error(message) %}
8+
{% include 'Lin3sAdminBundle:components:flash_message.html.twig' with {
9+
type: 'error',
10+
flash_message: message
11+
} %}
12+
{% endmacro %}

src/LIN3S/AdminBundle/Resources/views/layout.html.twig

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,19 @@
5353
</div>
5454
</header>
5555
{% block lin3s_admin_flash_messages %}
56-
{% include 'Lin3sAdminBundle:partial:flash.html.twig' %}
56+
{% import 'Lin3sAdminBundle:components/macros:flash_messages.html.twig' as flash_messages %}
57+
58+
{% for message in app.session.flashbag.get('lin3s_admin_error') %}
59+
{{ flash_messages.error(message) }}
60+
{% endfor %}
61+
62+
{% for message in app.session.flashbag.get('lin3s_admin_success') %}
63+
{{ flash_messages.success(message) }}
64+
{% endfor %}
5765
{% endblock %}
66+
5867
{% block lin3s_admin_content_top %}{% endblock %}
68+
5969
{% block lin3s_admin_content %}{% endblock %}
6070
</div>
6171
</main>

src/LIN3S/AdminBundle/Resources/views/partial/flash.html.twig

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
 (0)