Skip to content

Commit 753a0cc

Browse files
committed
Made final the doctrine querybuilder class
1 parent b11ed18 commit 753a0cc

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

src/LIN3S/AdminBundle/Repository/DoctrineQueryBuilder.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
use Doctrine\ORM\EntityManager;
1515
use Doctrine\ORM\Mapping\ClassMetadata;
16-
use Doctrine\ORM\QueryBuilder as DoctrineQB;
16+
use Doctrine\ORM\QueryBuilder;
1717
use LIN3S\AdminBundle\Configuration\Model\Entity;
1818
use LIN3S\AdminBundle\Configuration\Model\ListField;
1919
use Symfony\Component\HttpFoundation\Request;
@@ -23,7 +23,7 @@
2323
* @author Jagoba Perez <jagoba@lin3s.com>
2424
* @author Beñat Espiña <benatespina@gmail.com>
2525
*/
26-
class DoctrineQueryBuilder
26+
final class DoctrineQueryBuilder
2727
{
2828
private $manager;
2929

@@ -136,15 +136,15 @@ private function resolveAssociations(Entity $config, ClassMetadata $metadata)
136136
* @param string $criteriaBy The criteria key
137137
* @param string $criteria The criteria value
138138
* @param ClassMetadata $metadata The Doctrine class metadata
139-
* @param DoctrineQB $queryBuilder The query builder
139+
* @param QueryBuilder $queryBuilder The query builder
140140
*
141141
* @return array
142142
*/
143143
private function getQueryAliasAndFields(
144144
$criteriaBy,
145145
$criteria,
146146
ClassMetadata $metadata,
147-
DoctrineQB $queryBuilder
147+
QueryBuilder $queryBuilder
148148
) {
149149
$alias = null;
150150
$fields = null;
@@ -184,11 +184,11 @@ private function getQueryAliasAndFields(
184184
/**
185185
* Removes the duplicate joins of given query builder.
186186
*
187-
* @param DoctrineQB $queryBuilder The query builder
187+
* @param QueryBuilder $queryBuilder The query builder
188188
*
189-
* @return DoctrineQB
189+
* @return QueryBuilder
190190
*/
191-
private function removeDuplicateJoins(DoctrineQB $queryBuilder)
191+
private function removeDuplicateJoins(QueryBuilder $queryBuilder)
192192
{
193193
if (empty($queryBuilder->getDQLParts()['join'])) {
194194
return $queryBuilder;
@@ -214,7 +214,7 @@ private function removeDuplicateJoins(DoctrineQB $queryBuilder)
214214
}
215215

216216
private function addDefaultOrderBy(
217-
DoctrineQB $queryBuilder,
217+
QueryBuilder $queryBuilder,
218218
Request $request,
219219
Entity $config,
220220
$alias = null

0 commit comments

Comments
 (0)