Core (Tests): Improve the use of CMake's add_test() in LV_BUILD_TEST().

kaixiong · kaixiong · commit 3d00f5f05442 · 2023-02-04T07:59:25.000+08:00
diff --git a/libvisual/cmake/LVBuildTest.cmake b/libvisual/cmake/LVBuildTest.cmake
@@ -45,7 +45,9 @@ FUNCTION(LV_BUILD_TEST TEST_NAME)
     ${PARSE_ARGS_LINK_OPTIONS}
   )
 
-  ADD_TEST(${TEST_NAME}
-    ${CMAKE_COMMAND} -E chdir ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}/${TEST_NAME} ${PARSE_ARGS_ARGS}
+  ADD_TEST(NAME ${TEST_NAME}
+    COMMAND ${TEST_NAME} ${PARSE_ARGS_ARGS}
+    WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+    COMMAND_EXPAND_LISTS
   )
 ENDFUNCTION()

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,9 @@ FUNCTION(LV_BUILD_TEST TEST_NAME)`
`45`	`45`	`${PARSE_ARGS_LINK_OPTIONS}`
`46`	`46`	`)`
`47`	`47`
`48`		`- ADD_TEST(${TEST_NAME}`
`49`		`- ${CMAKE_COMMAND} -E chdir ${CMAKE_CURRENT_SOURCE_DIR} ${CMAKE_CURRENT_BINARY_DIR}/${TEST_NAME} ${PARSE_ARGS_ARGS}`
	`48`	`+ ADD_TEST(NAME ${TEST_NAME}`
	`49`	`+ COMMAND ${TEST_NAME} ${PARSE_ARGS_ARGS}`
	`50`	`+ WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}`
	`51`	`+ COMMAND_EXPAND_LISTS`
`50`	`52`	`)`
`51`	`53`	`ENDFUNCTION()`