Skip to content

Commit 93c3b42

Browse files
committed
Fix collectEntries params being required and unique
1 parent 5abbcf2 commit 93c3b42

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

lib/serialize/ComponentConstructor.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,9 @@ export class ComponentConstructor {
358358
parameters: subParameters,
359359
},
360360
};
361+
// Params for collected entries are never required, and can have more than one entry.
362+
parameterData.unique = false;
363+
parameterData.required = false;
361364
this.populateOptionalParameterFields(parameter, parameterData);
362365
parameters.push(parameter);
363366

test/serialize/ComponentConstructor.test.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -710,8 +710,6 @@ describe('ComponentConstructor', () => {
710710
},
711711
],
712712
},
713-
required: true,
714-
unique: true,
715713
},
716714
]);
717715
});
@@ -1063,8 +1061,6 @@ describe('ComponentConstructor', () => {
10631061
{
10641062
'@id': 'mp:a/b/file-param#MyClass_fieldA',
10651063
comment: 'Hi',
1066-
required: true,
1067-
unique: true,
10681064
range: {
10691065
'@type': 'mp:a/b/file-param#MyClass_fieldA_range',
10701066
parameters: [
@@ -1130,8 +1126,6 @@ describe('ComponentConstructor', () => {
11301126
{
11311127
'@id': 'mp:a/b/file-param#MyClass_fieldA',
11321128
comment: 'Hi',
1133-
required: true,
1134-
unique: true,
11351129
range: {
11361130
'@type': 'mp:a/b/file-param#MyClass_fieldA_range',
11371131
parameters: [
@@ -1315,7 +1309,6 @@ describe('ComponentConstructor', () => {
13151309
{
13161310
'@id': 'mp:a/b/file-param#MyClass_fieldA',
13171311
comment: 'Hi',
1318-
required: true,
13191312
range: {
13201313
'@type': 'mp:a/b/file-param#MyClass_fieldA_range',
13211314
parameters: [

0 commit comments

Comments
 (0)