Skip to content

Commit d4a7c77

Browse files
authored
chore: example failing commit (#66)
* chore: example failing commit * ci: fix quote issue in main pipeline * ci: fix issues with quotes in pipeline * ci: fix issue with quote setup-env * ci: fix quote issue in action yml * ci: ensure all tasks run in parallel * chore: remove unused code
1 parent 96c76dd commit d4a7c77

4 files changed

Lines changed: 11 additions & 14 deletions

File tree

.github/actions/code-quality/action.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,16 +14,16 @@ runs:
1414
using: "composite"
1515
steps:
1616
- name: Run Ruff Formatting
17-
if: inputs.check-type == "format"
17+
if: inputs.check-type == 'format'
1818
shell: bash
1919
run: poetry run ruff format --config pyproject.toml ${{ inputs.source-dir }}
2020

2121
- name: Run Ruff Linting
22-
if: inputs.check-type == "lint"
22+
if: inputs.check-type == 'lint'
2323
shell: bash
2424
run: poetry run ruff check --config pyproject.toml ${{ inputs.source-dir }}
2525

2626
- name: Run Mypy Type Checking
27-
if: inputs.check-type == "type-check"
27+
if: inputs.check-type == 'type-check'
2828
shell: bash
2929
run: poetry run mypy --config-file pyproject.toml ${{ inputs.source-dir }}

.github/actions/setup-env/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ runs:
2929
path: |
3030
~/.cache/pypoetry
3131
~/.poetry
32-
key: ${{ runner.os }}-poetry-${{ hashFiles("**/poetry.lock") }}${{ inputs.cache-key-suffix }}
32+
key: ${{ runner.os }}-poetry-${{ hashFiles('**/poetry.lock') }}${{ inputs.cache-key-suffix }}
3333

3434
- name: Install dependencies
3535
shell: bash

.github/workflows/main.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
source-dir: ${{ needs.config.outputs.source-dir }}
3434

3535
lint:
36-
needs: [ config, format ]
36+
needs: [ config, setup ]
3737
runs-on: ubuntu-latest
3838
steps:
3939
- uses: actions/checkout@v4
@@ -46,7 +46,7 @@ jobs:
4646
source-dir: ${{ needs.config.outputs.source-dir }}
4747

4848
type-check:
49-
needs: [ config, format ]
49+
needs: [ config, setup ]
5050
runs-on: ubuntu-latest
5151
steps:
5252
- uses: actions/checkout@v4
@@ -71,7 +71,7 @@ jobs:
7171

7272
release:
7373
needs: [ config, setup, format, lint, type-check, test ]
74-
if: github.ref == "refs/heads/main"
74+
if: github.ref == 'refs/heads/main'
7575
runs-on: ubuntu-latest
7676
steps:
7777
- uses: actions/checkout@v4
@@ -97,15 +97,15 @@ jobs:
9797
fi
9898
9999
- name: Find Previous Release
100-
if: env.CREATE_RELEASE == "true"
100+
if: env.CREATE_RELEASE == 'true'
101101
run: |
102102
PREV_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "")
103103
if [ -n "$PREV_TAG" ]; then
104104
echo "PREV_TAG=${PREV_TAG}" >> $GITHUB_ENV
105105
fi
106106
107107
- name: Generate Compare URL
108-
if: env.CREATE_RELEASE == "true"
108+
if: env.CREATE_RELEASE == 'true'
109109
run: |
110110
if [ -n "${{ env.PREV_TAG }}" ]; then
111111
echo "URL=${{ github.server_url }}/${{ github.repository }}/compare/${{ env.PREV_TAG }}...${{ env.VERSION }}" >> $GITHUB_ENV
@@ -114,7 +114,7 @@ jobs:
114114
fi
115115
116116
- name: Generate Changelog
117-
if: env.CREATE_RELEASE == "true"
117+
if: env.CREATE_RELEASE == 'true'
118118
run: |
119119
chmod +x .github/generate_changelog.sh
120120
source .github/generate_changelog.sh
@@ -128,7 +128,7 @@ jobs:
128128
echo "EOF" >> $GITHUB_ENV
129129
130130
- name: Create Release
131-
if: env.CREATE_RELEASE == "true"
131+
if: env.CREATE_RELEASE == 'true'
132132
uses: softprops/action-gh-release@v2
133133
with:
134134
tag_name: ${{ env.VERSION }}

.pre-commit-config.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@ repos:
1414
entry: poetry run ruff format
1515
language: python
1616
types_or: [ python, pyi, jupyter ]
17-
args: [ "--config", "pyproject.toml", "src/" ]
1817
pass_filenames: true
1918

2019
- id: ruff-lint
2120
name: Linting
2221
entry: poetry run ruff check
2322
language: python
2423
types_or: [ python, pyi, jupyter ]
25-
args: [ "--config", "pyproject.toml", "src/" ]
2624
pass_filenames: true
2725
exclude: tests
2826

@@ -31,5 +29,4 @@ repos:
3129
entry: poetry run mypy
3230
language: python
3331
types_or: [ python, pyi, jupyter ]
34-
args: [ "--config", "pyproject.toml", "src/" ]
3532
pass_filenames: true

0 commit comments

Comments
 (0)