Dispose transient RelayPropertyFor subscriptions

Author: ionite34

StabilityMatrix.Avalonia/ViewModels/Inference/ImageFolderCardViewModel.cs

@@ -36,7 +36,7 @@ namespace StabilityMatrix.Avalonia.ViewModels.Inference;
 [View(typeof(ImageFolderCard))]
 [ManagedService]
 [Transient]
-public partial class ImageFolderCardViewModel : ViewModelBase
+public partial class ImageFolderCardViewModel : DisposableViewModelBase
 {
     private readonly ILogger<ImageFolderCardViewModel> logger;
     private readonly IImageIndexService imageIndexService;
@@ -86,11 +86,13 @@ ServiceManager<ViewModelBase> vmFactory
             .Bind(LocalImages)
             .Subscribe();
 
-        settingsManager.RelayPropertyFor(
-            this,
-            vm => vm.ImageSize,
-            settings => settings.InferenceImageSize,
-            delay: TimeSpan.FromMilliseconds(250)
+        AddDisposable(
+            settingsManager.RelayPropertyFor(
+                this,
+                vm => vm.ImageSize,
+                settings => settings.InferenceImageSize,
+                delay: TimeSpan.FromMilliseconds(250)
+            )
         );
     }
 

StabilityMatrix.Avalonia/ViewModels/Inference/PromptCardViewModel.cs

@@ -28,7 +28,10 @@ namespace StabilityMatrix.Avalonia.ViewModels.Inference;
 [View(typeof(PromptCard))]
 [ManagedService]
 [Transient]
-public partial class PromptCardViewModel : LoadableViewModelBase, IParametersLoadableState, IComfyStep
+public partial class PromptCardViewModel
+    : DisposableLoadableViewModelBase,
+        IParametersLoadableState,
+        IComfyStep
 {
     private readonly IModelIndexService modelIndexService;
     private readonly ISettingsManager settingsManager;
@@ -75,11 +78,13 @@ SharedState sharedState
             vm.AvailableModules = [typeof(PromptExpansionModule)];
         });
 
-        settingsManager.RelayPropertyFor(
-            this,
-            vm => vm.IsAutoCompletionEnabled,
-            settings => settings.IsPromptCompletionEnabled,
-            true
+        AddDisposable(
+            settingsManager.RelayPropertyFor(
+                this,
+                vm => vm.IsAutoCompletionEnabled,
+                settings => settings.IsPromptCompletionEnabled,
+                true
+            )
         );
     }