<fix>[sdnController]: fix code review commemt

Resolves: ZCF-1365

Change-Id: I65767164636167726d6369726f63666b68666477

Author: ruansteve

build/pom.xml

@@ -636,6 +636,11 @@
                     <artifactId>ovn</artifactId>
                     <version>${project.version}</version>
                 </dependency>
+                <dependency>
+                    <groupId>org.zstack</groupId>
+                    <artifactId>zns</artifactId>
+                    <version>${project.version}</version>
+                </dependency>
                 <dependency>
                     <groupId>org.zstack</groupId>
                     <artifactId>observabilityServer</artifactId>

plugin/sdnController/src/main/java/org/zstack/sdnController/SdnControllerManagerImpl.java

@@ -921,7 +921,7 @@ public void beforeAllocateVmNic(VmNicInventory nic, VmInstanceSpec spec, Complet
         String controllerUuid = L2NetworkSystemTags.L2_NETWORK_SDN_CONTROLLER_UUID.getTokenByResourceUuid(
                 l2VO.getUuid(), L2NetworkSystemTags.L2_NETWORK_SDN_CONTROLLER_UUID_TOKEN);
         if (controllerUuid == null) {
-            completion.success();
+            completion.fail(operr(ORG_ZSTACK_SDNCONTROLLER_10006, "sdn l2 network[uuid:%s] is not attached controller", l2VO.getUuid()));
             return;
         }
 
@@ -947,7 +947,7 @@ public void afterReleaseVmNic(VmNicInventory nic, Completion completion) {
         String controllerUuid = L2NetworkSystemTags.L2_NETWORK_SDN_CONTROLLER_UUID.getTokenByResourceUuid(
                 l2VO.getUuid(), L2NetworkSystemTags.L2_NETWORK_SDN_CONTROLLER_UUID_TOKEN);
         if (controllerUuid == null) {
-            completion.success();
+            completion.fail(operr(ORG_ZSTACK_SDNCONTROLLER_10006, "sdn l2 network[uuid:%s] is not attached controller", l2VO.getUuid()));
             return;
         }