<fix>[compute]: handle l2 nic detach

Resolves: ZCF-2047

Change-Id: I8ca7e84446f10cedbc2afb6281638f50ea6cb764

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: ruansteve

compute/src/main/java/org/zstack/compute/vm/VmCascadeExtension.java

@@ -29,6 +29,7 @@
 import org.zstack.header.message.MessageReply;
 import org.zstack.header.network.l2.L2NetworkConstant;
 import org.zstack.header.network.l2.L2NetworkDetachStruct;
+import org.zstack.header.network.l2.L2NetworkInventory;
 import org.zstack.header.network.l2.L2NetworkVO;
 import org.zstack.header.network.l3.*;
 import org.zstack.header.vm.*;
@@ -105,6 +106,10 @@ protected int toDeletionOpCode(CascadeAction action) {
             return OP_DETACH_NIC;
         }
 
+        if (L2NetworkVO.class.getSimpleName().equals(action.getParentIssuer())) {
+            return OP_DETACH_NIC;
+        }
+
         if (VmInstanceVO.class.getSimpleName().equals(action.getParentIssuer())) {
             return OP_DELETION;
         }
@@ -328,6 +333,32 @@ protected List<DetachNicFromVmMsg> handleDeletionForIpRange(List<VmDeletionStruc
         return msgs;
     }
 
+    protected List<DetachNicFromVmMsg> handleDeletionForL2Network(List<VmDeletionStruct> vminvs, List<L2NetworkInventory> l2s) {
+        List<DetachNicFromVmMsg> msgs = new ArrayList<>();
+        List<String> l2Uuids = l2s.stream().map(L2NetworkInventory::getUuid).collect(Collectors.toList());
+        List<String> l3Uuids = Q.New(L3NetworkVO.class).in(L3NetworkVO_.l2NetworkUuid, l2Uuids)
+                .select(L3NetworkVO_.uuid).listValues();
+        if (l3Uuids.isEmpty()) {
+            return msgs;
+        }
+
+        for (VmDeletionStruct vm : vminvs) {
+            for (VmNicInventory nic : vm.getInventory().getVmNics()) {
+                if (!l3Uuids.contains(nic.getL3NetworkUuid())) {
+                    continue;
+                }
+
+                DetachNicFromVmMsg msg = new DetachNicFromVmMsg();
+                msg.setVmInstanceUuid(nic.getVmInstanceUuid());
+                msg.setVmNicUuid(nic.getUuid());
+                bus.makeTargetServiceIdByResourceUuid(msg, VmInstanceConstant.SERVICE_ID, vm.getInventory().getUuid());
+                msgs.add(msg);
+            }
+        }
+
+        return msgs;
+    }
+
     protected void handleDeletion(final CascadeAction action, final Completion completion) {
         int op = toDeletionOpCode(action);
         if (op == OP_NOPE) {
@@ -492,6 +523,10 @@ public void done(ErrorCodeList errorCodeList) {
                 List<IpRangeInventory> iprs = action.getParentIssuerContext();
                 List<DetachNicFromVmMsg> dmsgs = handleDeletionForIpRange(vminvs, iprs);
                 msgs.addAll(dmsgs);
+            } else if (L2NetworkVO.class.getSimpleName().equals(action.getParentIssuer())) {
+                List<L2NetworkInventory> l2s = action.getParentIssuerContext();
+                List<DetachNicFromVmMsg> dmsgs = handleDeletionForL2Network(vminvs, l2s);
+                msgs.addAll(dmsgs);
             }
 
             detachVmNicCascade(msgs, true, completion);
@@ -671,6 +706,40 @@ public List<VmInstanceVO> call() {
                 }
             }.call();
 
+            if (!vmvos.isEmpty()) {
+                ret = toVmDeletionStruct(vmvos);
+            }
+        } else if (L2NetworkVO.class.getSimpleName().equals(action.getParentIssuer())) {
+            final List<String> l2uuids = CollectionUtils.transformToList(
+                    (List<L2NetworkInventory>) action.getParentIssuerContext(),
+                    new Function<String, L2NetworkInventory>() {
+                        @Override
+                        public String call(L2NetworkInventory arg) {
+                            return arg.getUuid();
+                        }
+                    });
+
+            List<VmInstanceVO> vmvos = new Callable<List<VmInstanceVO>>() {
+                @Override
+                @Transactional(readOnly = true)
+                public List<VmInstanceVO> call() {
+                    String sql = "select vm from VmInstanceVO vm, VmNicVO nic, L3NetworkVO l3" +
+                            " where vm.type = :vmType" +
+                            " and vm.uuid = nic.vmInstanceUuid" +
+                            " and vm.state in (:vmStates)" +
+                            " and nic.l3NetworkUuid = l3.uuid" +
+                            " and l3.l2NetworkUuid in (:uuids)" +
+                            " group by vm.uuid";
+                    TypedQuery<VmInstanceVO> q = dbf.getEntityManager().createQuery(sql, VmInstanceVO.class);
+                    q.setParameter("vmType", VmInstanceConstant.USER_VM_TYPE);
+                    q.setParameter("vmStates", Arrays.asList(
+                            VmInstanceState.Stopped, VmInstanceState.Paused,
+                            VmInstanceState.Running, VmInstanceState.Destroyed));
+                    q.setParameter("uuids", l2uuids);
+                    return q.getResultList();
+                }
+            }.call();
+
             if (!vmvos.isEmpty()) {
                 ret = toVmDeletionStruct(vmvos);
             }