Commit 7b6ceea
committed
<fix>[core,kvm]: fix SSH session leak in CallBackNetworkChecker and KVMHost
1. CallBackNetworkChecker.stopAnsible() creates Ssh object but never
closes it, leaking JSch Session thread on every call.
2. KVMHost "check-host-is-taken-over" flow has the same pattern.
When a host continuously fails reconnect (e.g. sharedblock VG error),
each reconnect cycle leaks 1-2 SSH sessions. Over days this exhausts
heap memory (18000+ threads observed) causing MN OOM and Unknown status.
Fix: add finally { ssh.close() } to both code paths.
Resolves: ZSTAC-83305
Resolves: ZSTAC-82731
Change-Id: I786e766e79776d6b7a75786d776278696c76666f1 parent f15be32 commit 7b6ceea
2 files changed
Lines changed: 7 additions & 3 deletions
File tree
- core/src/main/java/org/zstack/core/ansible
- plugin/kvm/src/main/java/org/zstack/kvm
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| 75 | + | |
| 76 | + | |
75 | 77 | | |
76 | 78 | | |
77 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5573 | 5573 | | |
5574 | 5574 | | |
5575 | 5575 | | |
| 5576 | + | |
| 5577 | + | |
| 5578 | + | |
5576 | 5579 | | |
5577 | | - | |
5578 | | - | |
5579 | | - | |
5580 | 5580 | | |
5581 | 5581 | | |
5582 | 5582 | | |
| |||
5625 | 5625 | | |
5626 | 5626 | | |
5627 | 5627 | | |
| 5628 | + | |
| 5629 | + | |
5628 | 5630 | | |
5629 | 5631 | | |
5630 | 5632 | | |
| |||
0 commit comments