Skip to content

Commit d2020c5

Browse files
author
gitlab
committed
Merge branch 'fix/ZSTAC-79628' into '5.5.12'
<fix>[storage]: honor force flag to clean image cache for existing images with no VMs (ZSTAC-79628) See merge request zstackio/zstack!9252
2 parents 3a6ad0f + 944c7a8 commit d2020c5

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

plugin/ceph/src/main/java/org/zstack/storage/ceph/primary/CephImageCacheCleaner.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ protected GlobalConfig cleanupIntervalConfig() {
3434
@Transactional
3535
@Override
3636
protected List<ImageCacheShadowVO> createShadowImageCacheVOsForNewDeletedAndOld(String psUuid, ImageCacheCleanParam param) {
37-
List<Long> staleImageCacheIds = getStaleImageCacheIds(psUuid, false);
37+
List<Long> staleImageCacheIds = getStaleImageCacheIds(psUuid, param.includeReadyImage);
3838
if (staleImageCacheIds == null || staleImageCacheIds.isEmpty()) {
3939
return null;
4040
}

storage/src/main/java/org/zstack/storage/primary/ImageCacheCleaner.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,8 @@ private List<Long> queryCacheOfExpungedImage(String psUuid) {
387387

388388
@Transactional
389389
protected List<ImageCacheShadowVO> createShadowImageCacheVOsForNewDeletedAndOld(String psUuid, ImageCacheCleanParam param) {
390-
// 1. image has been deleted
391-
List<Long> staleImageCacheIds = getStaleImageCacheIds(psUuid, false);
390+
// 1. image has been deleted or force cleanup includes images still in ready state with no VMs using them
391+
List<Long> staleImageCacheIds = getStaleImageCacheIds(psUuid, param.includeReadyImage);
392392
if (staleImageCacheIds == null || staleImageCacheIds.isEmpty()) {
393393
return null;
394394
}

0 commit comments

Comments
 (0)