(feature) Support all datatypes (#97)

* Refactor to support array and collection types. Fixes #93

* Add list type support

* Add support for set types

* Add global parser tests for all datatypes

* Add specific resolvers

Author: Matthiee

CommandLineParser.Tests/Command/CommandInModelTests.cs

@@ -1,6 +1,5 @@
 using MatthiWare.CommandLine.Abstractions.Command;
 using MatthiWare.CommandLine.Core.Attributes;
-using System.Threading.Tasks;
 using Xunit;
 using Xunit.Abstractions;
 

CommandLineParser.Tests/CommandLineParserTests.cs

@@ -779,6 +779,7 @@ private StringType2(string input)
 
             public string Result { get; }
 
+#pragma warning disable IDE0060 // Remove unused parameter
             public static bool TryParse(string input, IFormatProvider format, out StringType2 result)
             {
                 result = new StringType2(input);
@@ -853,6 +854,7 @@ public static StringType5 Parse(string input, IFormatProvider provider, IFormatP
             {
                 return null;
             }
+#pragma warning restore IDE0060 // Remove unused parameter
         }
 
         private class OrderModel

CommandLineParser.Tests/OptionBuilderTest.cs

@@ -22,7 +22,7 @@ public void OptionBuilderConfiguresOptionCorrectly()
                 new CommandLineParserOptions { PrefixLongOption = string.Empty, PrefixShortOption = string.Empty },
                 new object(),
                 XUnitExtensions.CreateLambda<object, string>(o => o.ToString()),
-                new DefaultResolver<object>(NullLogger<CommandLineParser>.Instance), NullLogger.Instance);
+                new DefaultResolver<object>(NullLogger<CommandLineParser>.Instance, serviceProviderMock.Object), NullLogger.Instance);
 
             var builder = cmdOption as IOptionBuilder;
             var option = cmdOption as CommandLineOptionBase;

CommandLineParser.Tests/Parsing/OptionClusteringTests.cs

@@ -1,7 +1,4 @@
 using MatthiWare.CommandLine.Core.Attributes;
-using System;
-using System.Collections.Generic;
-using System.Text;
 using Xunit;
 using Xunit.Abstractions;
 

CommandLineParser.Tests/Parsing/Resolvers/BoolResolverTests.cs

@@ -23,7 +23,7 @@ public void TestResolveTrue(string input)
         {
             var resolver = ServiceProvider.GetRequiredService<IArgumentResolver<bool>>();
 
-            var result = resolver.Resolve(new ArgumentModel { Value = input });
+            var result = resolver.Resolve(new ArgumentModel(string.Empty, input));
 
             Assert.True(result);
         }
@@ -36,7 +36,7 @@ public void TestResolveFalse(string input)
         {
             var resolver = ServiceProvider.GetRequiredService<IArgumentResolver<bool>>();
 
-            var result = resolver.Resolve(new ArgumentModel { Value = input });
+            var result = resolver.Resolve(new ArgumentModel(string.Empty, input));
 
             Assert.False(result);
         }

CommandLineParser.Tests/Parsing/Resolvers/DefaultResolverTests.cs

@@ -1,6 +1,9 @@
 using MatthiWare.CommandLine.Abstractions.Models;
 using MatthiWare.CommandLine.Abstractions.Parsing;
+using MatthiWare.CommandLine.Core.Parsing.Resolvers;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Logging.Abstractions;
+using System;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -13,6 +16,24 @@ public DefaultResolverTests(ITestOutputHelper outputHelper) : base(outputHelper)
         {
         }
 
+        [Fact]
+        public void ThrowsExceptionInCorrectPlaces()
+        {
+            Assert.Throws<ArgumentNullException>(() => new DefaultResolver<object>(null, null));
+            Assert.Throws<ArgumentNullException>(() => new DefaultResolver<object>(NullLogger<CommandLineParser>.Instance, null));
+            Assert.Throws<NotImplementedException>(() => new DefaultResolver<object>(NullLogger<CommandLineParser>.Instance, ServiceProvider).CanResolve(""));
+            Assert.Throws<NotImplementedException>(() => new DefaultResolver<object>(NullLogger<CommandLineParser>.Instance, ServiceProvider).Resolve(""));
+        }
+
+        [Fact]
+        public void WorksCorrectlyWithNullValues()
+        {
+            var resolver = new DefaultResolver<object>(NullLogger<CommandLineParser>.Instance, ServiceProvider);
+
+            Assert.False(resolver.CanResolve((ArgumentModel)null));
+            Assert.Null(resolver.Resolve((ArgumentModel)null));
+        }
+
         [Theory]
         [InlineData(true, "-m", "test")]
         [InlineData(true, "-m", "my string")]