Fixed bug in Updater that supresses the error from the user.

Author: Matthiee

UpdateLib/TestApp/Program.cs

@@ -26,7 +26,7 @@ static void Main()
 
         private static void InitializeUpdater()
         {
-            //Updater.Instance.Initialize();
+            Updater.Instance.Initialize();
             Updater.Instance.UpdateURL = "https://raw.githubusercontent.com/MatthiWare/UpdateLib.TestApp.UpdateExample/master/Dev/updatefile.xml";
             //Updater.Instance.UpdateURL = "http://matthiware.dev/UpdateLib/Dev/updatefile.xml";
         }

UpdateLib/UpdateLib/Files/HashCacheFile.cs

@@ -27,7 +27,7 @@ private static string GetStoragePath()
             {
                 string appdata = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
                 string name = Assembly.GetEntryAssembly().GetName().Name;
-                storagePath = $@"{appdata}\{name}\MatthiWare.UpdateLib\Cache\HashCacheFile.xml";
+                storagePath = $@"{appdata}\{name}\UpdateLib\Cache\HashCacheFile.xml";
             }
 
             return storagePath;

UpdateLib/UpdateLib/Logging/Writers/FileLogWriter.cs

@@ -19,7 +19,7 @@ public FileLogWriter()
         {
             string appdata = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
             string name = Assembly.GetEntryAssembly().GetName().Name;
-            logFile = new FileInfo($@"{appdata}\{name}\MatthiWare.UpdateLib\Log\log_{DateTime.Now.ToString("yyyyMMdd")}.log");
+            logFile = new FileInfo($@"{appdata}\{name}\UpdateLib\Log\log_{DateTime.Now.ToString("yyyyMMdd")}.log");
 
             if (!logFile.Directory.Exists)
                 logFile.Directory.Create();

UpdateLib/UpdateLib/Tasks/CheckForUpdatedFilesTask.cs

@@ -5,23 +5,39 @@ namespace MatthiWare.UpdateLib.Tasks
 {
     public class CheckForUpdatedFilesTask : AsyncTask<bool>
     {
-        private UpdateFile updateFile;
-        private HashCacheFile cacheFile;
-        private PathVariableConverter converter;
+        private UpdateFile m_updateFile;
+        private HashCacheFile m_cacheFile;
+        private PathVariableConverter m_converter;
 
         public CheckForUpdatedFilesTask(UpdateFile update, HashCacheFile cache, PathVariableConverter converter)
         {
-            updateFile = update;
-            cacheFile = cache;
-            this.converter = converter;
+            if (update == null) throw new ArgumentNullException(nameof(update));
+            if (cache == null) throw new ArgumentNullException(nameof(cache));
+            if (converter == null) throw new ArgumentNullException(nameof(converter));
+
+            m_updateFile = update;
+            m_cacheFile = cache;
+            m_converter = converter;
+        }
+
+        protected override void DoWork()
+        {
+            Action<DirectoryEntry> call = new Action<DirectoryEntry>(RecursiveCheck);
+
+            foreach (DirectoryEntry dir in m_updateFile.Folders)
+                Enqueue(call, dir);
+
+            AwaitWorkers();
+
+            Result = m_updateFile.Count > 0;
         }
 
         private void RecursiveCheck(DirectoryEntry dir)
         {
             dir.Files.RemoveAll(fe =>
             {
-                string convertedPath = converter.Replace(fe.DestinationLocation);
-                HashCacheEntry cacheEntry = cacheFile.Items.Find(hash => hash.FilePath.Equals(convertedPath));
+                string convertedPath = m_converter.Replace(fe.DestinationLocation);
+                HashCacheEntry cacheEntry = m_cacheFile.Items.Find(hash => hash.FilePath.Equals(convertedPath));
 
                 if (cacheEntry == null)
                     return false;
@@ -35,17 +51,5 @@ private void RecursiveCheck(DirectoryEntry dir)
             foreach (DirectoryEntry de in dir.Directories)
                 Enqueue(call, de);
         }
-
-        protected override void DoWork()
-        {
-            Action<DirectoryEntry> call = new Action<DirectoryEntry>(RecursiveCheck);
-
-            foreach (DirectoryEntry dir in updateFile.Folders)
-                Enqueue(call, dir);
-
-            AwaitWorkers();
-
-            Result = updateFile.Count > 0;
-        }
     }
 }

UpdateLib/UpdateLib/Updater.cs

@@ -83,7 +83,7 @@ public void Initialize()
             CleanUpTask.ConfigureAwait(false).Start();
 
             UpdateCacheTask = new UpdateCacheTask();
-            UpdateCacheTask.Start();
+            UpdateCacheTask.ConfigureAwait(false).Start();
 
             initialized = true;
         }
@@ -130,10 +130,13 @@ public CheckForUpdatesTask CheckForUpdatesAsync(IWin32Window owner)
                 throw new ArgumentException("You need to specifify an update url", nameof(UpdateURL));
 
             CheckForUpdatesTask task = new CheckForUpdatesTask(UpdateURL);
-            task.TaskCompleted += (o, e) => 
+            task.TaskCompleted += (o, e) =>
             {
-                if (!task.Result.UpdateAvailable) // no updates available
+                if (!task.Result.UpdateAvailable || e.Cancelled || e.Error != null)
+                {
+                    CheckForUpdatesCompleted?.Invoke(task, new CheckForUpdatesCompletedEventArgs(task.Result, e));
                     return;
+                }
 
                 DialogResult result = MessageDialog.Show(
                         "Update available",