Skip to content

Commit f59da69

Browse files
authored
Fix version guessing for paths without extensions, or extensions other then .jar (#34)
1 parent ee35db4 commit f59da69

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

src/main/java/cpw/mods/jarhandling/JarMetadata.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,12 @@ static SimpleJarMetadata fromFileName(final Path path, final Set<String> pkgs, f
7575
}
7676

7777
// fallback parsing
78-
var fn = path.getFileName().toString();
79-
fn = fn.substring(0, fn.length()-4); // no .jar extension
78+
var fn = path.getFileName().toString();
79+
var lastDot = fn.lastIndexOf('.');
80+
if (lastDot > 0) {
81+
fn = fn.substring(0, lastDot); // strip extension if possible
82+
}
83+
8084
var mat = DASH_VERSION.matcher(fn);
8185
if (mat.find()) {
8286
var ver = ModuleDescriptor.Version.parse(fn.substring(mat.start() + 1)).toString();

0 commit comments

Comments
 (0)