Skip to content

Commit 7b726e1

Browse files
committed
Modified according to PR comments.
1 parent d1bbcc2 commit 7b726e1

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

.github/workflows/deploy-snapshot.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ jobs:
4242
${{ runner.os }}-
4343
- name: Load secrets from 1Password
4444
if: env.HAS_1PASSWORD == 'true'
45-
uses: MobilityData/gtfs-validator/.github/actions/extract-1password-secret@master
45+
# Pinned to a specific tag for supply-chain safety. Update the tag in gtfs-validator if the action changes.
46+
uses: MobilityData/gtfs-validator/.github/actions/extract-1password-secret@USED_BY_GBFS_VALIDATOR_JAVA # 7bf2832
4647
with:
4748
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
4849
VARIABLES_TO_EXTRACT: 'MAVEN_GPG_PASSPHRASE, MAVEN_GPG_PRIVATE_KEY, MAVEN_CENTRAL_PORTAL_TOKEN_USERNAME, MAVEN_CENTRAL_PORTAL_TOKEN_PASSWORD'
@@ -63,6 +64,14 @@ jobs:
6364
echo "MAVEN_CENTRAL_PORTAL_TOKEN_USERNAME=$MVN_USER"
6465
echo "MAVEN_CENTRAL_PORTAL_TOKEN_PASSWORD=$MVN_PASS"
6566
} >> "$GITHUB_ENV"
67+
- name: Verify version is not placeholder
68+
run: |
69+
VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
70+
if [[ "$VERSION" == *"placeholder"* || "$VERSION" == "0.0.0"* ]]; then
71+
echo "ERROR: Version is still '$VERSION' — git-versioning extension failed to resolve. Aborting."
72+
exit 1
73+
fi
74+
echo "Version OK: $VERSION"
6675
- name: Stage artifacts
6776
run: mvn deploy -Ppublication -Dprettier.skip=true -ntp
6877
- name: Publish snapshot to Maven Central

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ jobs:
4545
${{ runner.os }}-
4646
- name: Load secrets from 1Password
4747
if: env.HAS_1PASSWORD == 'true'
48-
uses: MobilityData/gtfs-validator/.github/actions/extract-1password-secret@master
48+
# Pinned to a specific tag for supply-chain safety. Update the tag in gtfs-validator if the action changes.
49+
uses: MobilityData/gtfs-validator/.github/actions/extract-1password-secret@USED_BY_GBFS_VALIDATOR_JAVA # 7bf2832
4950
with:
5051
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}
5152
VARIABLES_TO_EXTRACT: 'MAVEN_GPG_PASSPHRASE, MAVEN_GPG_PRIVATE_KEY, MAVEN_CENTRAL_PORTAL_TOKEN_USERNAME, MAVEN_CENTRAL_PORTAL_TOKEN_PASSWORD'

0 commit comments

Comments
 (0)