Skip to content

Commit e6861ca

Browse files
committed
typo and doc soecifications
1 parent d65cc06 commit e6861ca

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ npx firebase hosting:channel:deploy {channel_name}
8787

8888
# Firebase Remote Configs
8989

90-
Firebase remoet configs help us toggle new features on and off. Due to the nature of static pages, there are some nuances. For static pages, the remote configs are called and set at build time and will be the same for the remainder of the static page's cache.
90+
Firebase remote configs help us toggle new features on and off. Due to the nature of static pages, there are some nuances. For static pages, the remote configs are called and set at build time and will be the same for the remainder of the static page's cache.
9191

92-
When remote configs change (they rarily do), it is recommended to redploy the app as that will trigger a new cache for all pages, that will include the updated remote configs
92+
When remote configs change (they rarily do), it is recommended to redeploy the app as that will trigger a new cache for all pages, that will include the updated remote configs
9393

9494
What this also means is that client components will be able to access the firebase remote configs using the Context but server components will have to fetch them each time. This isn't a big deal as the firebase remote configs are cached (for 1 hour on the server)
9595

src/lib/remote-config.server.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ export async function refreshRemoteConfig(): Promise<RemoteConfigValues> {
139139

140140
/**
141141
* Returns a copy of the config with all boolean flags set to `true`.
142-
* Used to give internal @mobilitydata.org users access to all features.
142+
* Used to give specific users ex: internal @mobilitydata.org users access to all features.
143143
* Exported for use in server components that receive isAdmin as a prop.
144144
*/
145145
export function applyAdminBypass(
@@ -158,7 +158,7 @@ export function applyAdminBypass(
158158

159159
/**
160160
* Get Remote Config values for a specific user.
161-
* @mobilitydata.org users receive all boolean feature flags enabled.
161+
* Specific users ex: @mobilitydata.org users receive all boolean feature flags enabled.
162162
*/
163163
export async function getRemoteConfigValuesForUser(
164164
email?: string,

0 commit comments

Comments
 (0)