Refactor CMake

Author: jgeudens

CMakeLists.txt

@@ -6,8 +6,6 @@ project(notonlymodbusscope
     VERSION 0.0.1
 )
 
-add_definitions("-DDEBUG")
-
 set(SCOPESOURCE ScopeSource)
 
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
@@ -50,26 +48,17 @@ set(QT_LIB
     Qt::SerialPort
 )
 
-include_directories(
-    ${CMAKE_CURRENT_SOURCE_DIR}/src
-    ${CMAKE_CURRENT_SOURCE_DIR}/libraries
-)
-
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wextra")
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror")
+add_compile_options(-Wall -Wextra -Werror)
 if (MINGW)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wa,-mbig-obj")
+    add_compile_options(-Wa,-mbig-obj)
 endif()
 
-
-if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     # Code Coverage Report
     if(USE_GCOV)
-            message(STATUS "Enabling coverage")
-            set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} --coverage")
-            set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} --coverage")
-            set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} --coverage")
+        message(STATUS "Enabling coverage")
+        add_compile_options(--coverage)
+        add_link_options(--coverage)
     endif()
 endif()
 

libraries/muparser/CMakeLists.txt

@@ -42,7 +42,7 @@ elseif(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-long-long -pedantic")
 endif()
 
-FILE(GLOB_RECURSE MUPARSER_SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp") #all .cpp
+FILE(GLOB_RECURSE MUPARSER_SOURCES CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp") #all .cpp
 add_library(muparser ${MUPARSER_SOURCES})
 
 # Use the headers in the build-tree or the installed ones

src/CMakeLists.txt

@@ -18,18 +18,25 @@ execute_process(
 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/util/version.h.in ${CMAKE_CURRENT_SOURCE_DIR}/util/version.h)
 configure_file(${CMAKE_CURRENT_SOURCE_DIR}/../resources/modbusscope.rc.in ${CMAKE_CURRENT_SOURCE_DIR}/../resources/modbusscope.rc)
 
-FILE(GLOB_RECURSE SRCS "${CMAKE_CURRENT_SOURCE_DIR}/*.cpp" "${CMAKE_CURRENT_SOURCE_DIR}/*.h") #all .cpp/.h in current "src" folder and sub folders
-FILE(GLOB_RECURSE UIS "${CMAKE_CURRENT_SOURCE_DIR}/*.ui") #all .ui in current "src" folder and sub folders
+file(GLOB_RECURSE SRCS CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/*.cpp" "${CMAKE_CURRENT_SOURCE_DIR}/*.h") #all .cpp/.h in current "src" folder and sub folders
+file(GLOB_RECURSE UIS CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/*.ui") #all .ui in current "src" folder and sub folders
 
-qt_add_library (${SCOPESOURCE} STATIC ${SRCS} ${UIS})
+qt_add_library(${SCOPESOURCE} STATIC ${SRCS} ${UIS})
+
+target_compile_definitions(${SCOPESOURCE} PRIVATE DEBUG)
+
+target_include_directories(${SCOPESOURCE} PUBLIC
+    ${CMAKE_CURRENT_SOURCE_DIR}
+    ${CMAKE_CURRENT_SOURCE_DIR}/../libraries
+)
 
 # Default GUI type is blank
 set(GUI_TYPE "")
 
 if(WIN32)
     set(GUI_TYPE WIN32)
     set(target_dir "bin/win")
-elseif(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
+elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
     set(target_dir "bin/linux")
 else()
     message(SEND_ERROR "You are on an unsupported platform! (Not Win or Unix)")
@@ -62,10 +69,10 @@ add_custom_command(TARGET ${PROJECT_NAME} POST_BUILD
 )
 
 # Do platform specific post target stuff
-if(${CMAKE_SYSTEM_NAME} MATCHES "Linux")
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
 
     install(TARGETS ${PROJECT_NAME} RUNTIME DESTINATION bin)
 
 elseif(WIN32)
     # not required
-endif (${CMAKE_SYSTEM_NAME} MATCHES "Linux")
+endif (CMAKE_SYSTEM_NAME STREQUAL "Linux")

tests/CMakeLists.txt

@@ -1,5 +1,3 @@
-add_definitions(-DGTEST_LANGUAGE_CXX11)
-
 find_package(Threads REQUIRED)
 
 if ($ENV{GOOGLETEST_DIR})
@@ -16,8 +14,6 @@ else ()
     message( FATAL_ERROR "No googletest src dir found - set GOOGLETEST_DIR to enable!")
 endif ()
 
-include_directories(${GTestSrc} ${GTestSrc}/include ${GMockSrc} ${GMockSrc}/include)
-
 set(
     GOOGLE_TEST_SOURCE
     ${GTestSrc}/src/gtest-all.cc
@@ -43,6 +39,8 @@ function(add_xtest_mock SOURCE_NAME)
         ${SOURCE_NAME}.cpp
         ${GOOGLE_TEST_SOURCE}
 		${ARGN})
+	target_include_directories(${SOURCE_NAME} PRIVATE ${GTestSrc} ${GTestSrc}/include ${GMockSrc} ${GMockSrc}/include)
+	target_compile_definitions(${SOURCE_NAME} PRIVATE GTEST_LANGUAGE_CXX11)
 	target_link_libraries(${SOURCE_NAME} Qt::Test Threads::Threads ${QT_LIB} ${SCOPESOURCE})
 	add_test(NAME ${SOURCE_NAME} COMMAND ${SOURCE_NAME})
 endfunction()