Review remarks

jgeudens · jgeudens · commit 2f7305fc6ee1 · 2026-03-29T19:13:23.000+02:00
diff --git a/src/customwidgets/schemaformwidget.cpp b/src/customwidgets/schemaformwidget.cpp
@@ -104,7 +104,7 @@ void SchemaFormWidget::setSchema(const QJsonObject& schema, const QJsonObject& v
         _pFormLayout->addRow(label + ":", widget);
     }
 
-    applyConditional(values.value(_conditionalTriggerKey).toString());
+    applyConditional(values.value(_conditionalTriggerKey).toVariant().toString());
 
     for (const auto& [key, widget] : std::as_const(_fields))
     {
@@ -232,7 +232,7 @@ bool SchemaFormWidget::parseConditional(const QJsonObject& schema)
     }
 
     _conditionalTriggerKey = triggerKey;
-    _conditionalTriggerConst = constObj.value("const").toString();
+    _conditionalTriggerConst = constObj.value("const").toVariant().toString();
 
     const QJsonObject thenProps = thenObj.value("properties").toObject();
     for (auto it = thenProps.constBegin(); it != thenProps.constEnd(); ++it)

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ void SchemaFormWidget::setSchema(const QJsonObject& schema, const QJsonObject& v`
`104`	`104`	`_pFormLayout->addRow(label + ":", widget);`
`105`	`105`	`}`
`106`	`106`
`107`		`- applyConditional(values.value(_conditionalTriggerKey).toString());`
	`107`	`+ applyConditional(values.value(_conditionalTriggerKey).toVariant().toString());`
`108`	`108`
`109`	`109`	`for (const auto& [key, widget] : std::as_const(_fields))`
`110`	`110`	`{`
`@@ -232,7 +232,7 @@ bool SchemaFormWidget::parseConditional(const QJsonObject& schema)`
`232`	`232`	`}`
`233`	`233`
`234`	`234`	`_conditionalTriggerKey = triggerKey;`
`235`		`- _conditionalTriggerConst = constObj.value("const").toString();`
	`235`	`+ _conditionalTriggerConst = constObj.value("const").toVariant().toString();`
`236`	`236`
`237`	`237`	`const QJsonObject thenProps = thenObj.value("properties").toObject();`
`238`	`238`	`for (auto it = thenProps.constBegin(); it != thenProps.constEnd(); ++it)`