refactor: enforce consistent type imports and exports in TypeScript files

gabriel-logan · gabriel-logan · commit 6b17155105d9 · 2025-02-05T18:06:09.000-03:00
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -46,6 +46,8 @@ export default tseslint.config(
           },
         },
       ],
+      "@typescript-eslint/consistent-type-imports": "error",
+      "@typescript-eslint/consistent-type-exports": "error",
     },
   },
 );
diff --git a/src/validateBRPhoneNumber.ts b/src/validateBRPhoneNumber.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "Field phone number cannot be empty",
diff --git a/src/validateEmail.ts b/src/validateEmail.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 import isEmail from "./isEmail";
 
 const defaultErrorMsg: string[] = [
diff --git a/src/validateName.ts b/src/validateName.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "Name cannot be empty",
diff --git a/src/validatePassportNumber.ts b/src/validatePassportNumber.ts
@@ -1,4 +1,4 @@
-import { ValidatePassportNumber } from "./types";
+import type { ValidatePassportNumber } from "./types";
 
 /**
  * @example validatePassportNumber('A1234567');
diff --git a/src/validatePassword.ts b/src/validatePassword.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "This password is too long",
diff --git a/src/validatePhoneNumber.ts b/src/validatePhoneNumber.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "Phone number cannot be empty",
diff --git a/src/validateSurname.ts b/src/validateSurname.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "Surname cannot be empty",
diff --git a/src/validateTextarea.ts b/src/validateTextarea.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "This textarea is too big",
diff --git a/src/validateUSPhoneNumber.ts b/src/validateUSPhoneNumber.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "US phone number cannot be empty",
diff --git a/src/validateUsername.ts b/src/validateUsername.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "./types";
+import type { ValidateFunctions } from "./types";
 
 const defaultErrorMsg: string[] = [
   "Username cannot be empty",
diff --git a/tests/src/passwordStrengthTester.test.ts b/tests/src/passwordStrengthTester.test.ts
@@ -1,5 +1,5 @@
 import { passwordStrengthTester } from "../../index";
-import { PasswordStrengthTesterOptions } from "../../src/passwordStrengthTester";
+import type { PasswordStrengthTesterOptions } from "../../src/passwordStrengthTester";
 
 describe("passwordStrengthTester function", () => {
   let options: PasswordStrengthTesterOptions;
diff --git a/tests/src/validateBRPhoneNumber.test.ts b/tests/src/validateBRPhoneNumber.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validateBRPhoneNumber from "../../src/validateBRPhoneNumber";
 
 describe("validateBRPhoneNumber", () => {
diff --git a/tests/src/validateEmail.test.ts b/tests/src/validateEmail.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validateEmail from "../../src/validateEmail";
 
 describe("validateEmail", () => {
diff --git a/tests/src/validateName.test.ts b/tests/src/validateName.test.ts
@@ -1,5 +1,5 @@
 import validateName from "../../src/validateName";
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 
 describe("validateName", () => {
   it("should return isValid as true for valid names", () => {
diff --git a/tests/src/validatePassportNumber.test.ts b/tests/src/validatePassportNumber.test.ts
@@ -1,4 +1,4 @@
-import { ValidatePassportNumber } from "../../src/types";
+import type { ValidatePassportNumber } from "../../src/types";
 import validatePassportNumber from "../../src/validatePassportNumber";
 
 describe("validatePassportNumber", () => {
diff --git a/tests/src/validatePassword.test.ts b/tests/src/validatePassword.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validatePassword from "../../src/validatePassword";
 
 describe("validatePassword", () => {
diff --git a/tests/src/validatePhoneNumber.test.ts b/tests/src/validatePhoneNumber.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validatePhoneNumber from "../../src/validatePhoneNumber";
 
 describe("validatePhoneNumber", () => {
diff --git a/tests/src/validateSurname.test.ts b/tests/src/validateSurname.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validateSurname from "../../src/validateSurname";
 
 describe("validateSurname", () => {
diff --git a/tests/src/validateTextarea.test.ts b/tests/src/validateTextarea.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validateTextarea from "../../src/validateTextarea";
 
 describe("validateTextarea", () => {
diff --git a/tests/src/validateUSPhoneNumber.test.ts b/tests/src/validateUSPhoneNumber.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validateUSPhoneNumber from "../../src/validateUSPhoneNumber";
 
 describe("validateUSPhoneNumber", () => {
diff --git a/tests/src/validateUsername.test.ts b/tests/src/validateUsername.test.ts
@@ -1,4 +1,4 @@
-import { ValidateFunctions } from "../../src/types";
+import type { ValidateFunctions } from "../../src/types";
 import validateUsername from "../../src/validateUsername";
 
 describe("validateUsername", () => {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { ValidateFunctions } from "./types";`
	`1`	`+import type { ValidateFunctions } from "./types";`
`2`	`2`
`3`	`3`	`const defaultErrorMsg: string[] = [`
`4`	`4`	`"Field phone number cannot be empty",`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { ValidatePassportNumber } from "./types";`
	`1`	`+import type { ValidatePassportNumber } from "./types";`
`2`	`2`
`3`	`3`	`/**`
`4`	`4`	`* @example validatePassportNumber('A1234567');`