removed some breaking code

Author: adam-wallernhs1

tests/e2e/tests/conftest.py

@@ -46,25 +46,3 @@ def _setup(scenario, config_path):
         return nhs_number, config_filenames, request_headers, query_params, expected_response_code
 
     return _setup
-
-@pytest.fixture(scope="session")
-def validate_against_spec():
-    """
-    Validates an API response against the Eligibility Signposting API spec.
-    Loads the spec once per test session.
-    """
-    parser = ResolvingParser(SPEC_PATH)
-    openapi_spec = parser.specification
-
-    def _validate(status_code, response_body):
-        try:
-            method_spec = openapi_spec["paths"][API_PATH][API_METHOD]
-            response_schema = method_spec["responses"][str(status_code)]["content"]["application/json"]["schema"]
-
-            validate(instance=response_body, schema=response_schema)
-        except KeyError as e:
-            pytest.fail(f"Spec does not define schema for GET {API_PATH} {status_code}: {e}")
-        except Exception as e:
-            pytest.fail(f"Schema validation failed: {e}")
-
-    return _validate

tests/e2e/tests/test_story_tests.py

@@ -16,7 +16,7 @@
 
 @pytest.mark.functionale2eregression
 @pytest.mark.parametrize(("filename", "scenario"), param_list, ids=id_list)
-def test_run_story_test_cases(filename, scenario, eligibility_client, get_scenario_params, validate_against_spec):
+def test_run_story_test_cases(filename, scenario, eligibility_client, get_scenario_params):
     nhs_number, config_filenames, request_headers, query_params, expected_response_code = get_scenario_params(scenario, config_path)
 
     actual_response = eligibility_client.make_request(
@@ -25,7 +25,7 @@ def test_run_story_test_cases(filename, scenario, eligibility_client, get_scenar
     expected_response = all_expected_responses.get(filename).get("response_items", {})
     expected_response_code = expected_response_code or http.HTTPStatus.OK
 
-    assert actual_response["status_code"] == http.HTTPStatus.OK
+    assert actual_response["status_code"] == expected_response_code
     assert actual_response["body"] == expected_response, (
         f"\n❌ Mismatch in test: {filename}\n"
         f"NHS Number: {nhs_number}\n"