lint fixes

Author: Karthikeyannhs

src/rules_validation_api/validators/campaign_config_validator.py

@@ -1,4 +1,4 @@
-from pydantic import Field, field_validator
+from pydantic import Field
 
 from eligibility_signposting_api.model.campaign_config import CampaignConfig
 from rules_validation_api.validators.iteration_validator import IterationValidation

src/rules_validation_api/validators/iteration_validator.py

@@ -18,14 +18,11 @@ def validate_default_comms_routing_in_actions_mapper(self):
         if default_routing:
             if not actions_mapper or default_routing not in actions_mapper:
                 error = InitErrorDetails(
-                    type='value_error',
-                    loc=('actions_mapper',),
+                    type="value_error",
+                    loc=("actions_mapper",),
                     input=actions_mapper,
-                    ctx={'error': f"Missing entry for DefaultCommsRouting '{default_routing}' in ActionsMapper"}
-                )
-                raise ValidationError.from_exception_data(
-                    title='IterationValidation',
-                    line_errors=[error]
+                    ctx={"error": f"Missing entry for DefaultCommsRouting '{default_routing}' in ActionsMapper"},
                 )
+                raise ValidationError.from_exception_data(title="IterationValidation", line_errors=[error])
 
         return self

tests/unit/validation/conftest.py

@@ -28,17 +28,15 @@ def valid_campaign_config_with_only_mandatory_fields():
                 "DefaultNotActionableRouting": "RouteC",
                 "IterationCohorts": [],
                 "IterationRules": [],
-                "ActionsMapper":
-                    {
-                        "BOOK_NBS":
-                            {
-                                "ExternalRoutingCode": "BookNBS",
-                                "ActionDescription": "",
-                                "ActionType": "ButtonWithAuthLink",
-                                "UrlLink": "http://www.nhs.uk/book-rsv",
-                                "UrlLabel": "Continue to booking"
-                            }
+                "ActionsMapper": {
+                    "BOOK_NBS": {
+                        "ExternalRoutingCode": "BookNBS",
+                        "ActionDescription": "",
+                        "ActionType": "ButtonWithAuthLink",
+                        "UrlLink": "http://www.nhs.uk/book-rsv",
+                        "UrlLabel": "Continue to booking",
                     }
+                },
             }
         ],
     }
@@ -67,5 +65,5 @@ def valid_available_action():
         "ActionDescription": "",
         "ActionType": "ButtonWithAuthLink",
         "UrlLink": "http://www.nhs.uk/book-rsv",
-        "UrlLabel": "Continue to booking"
+        "UrlLabel": "Continue to booking",
     }

tests/unit/validation/test_available_action_validator.py

@@ -8,7 +8,6 @@
 
 # 🔍 Mandatory Fields
 class TestMandatoryFieldsSchemaValidations:
-
     def test_valid_minimal_input(self, valid_available_action):
         data = copy.deepcopy(valid_available_action)
         data.pop("ActionDescription")
@@ -34,7 +33,6 @@ def test_missing_required_fields(self, valid_available_action):
 
 # 🔍 Optional Fields
 class TestOptionalFieldsSchemaValidations:
-
     def test_valid_full_input(self, valid_available_action):
         action = AvailableActionValidation(**valid_available_action)
         assert action.action_type == "ButtonWithAuthLink"

tests/unit/validation/test_iteration_validator.py

@@ -143,34 +143,39 @@ def test_approval_maximum(self, approval_maximum, valid_campaign_config_with_onl
 
 
 class TestIterationCohortsSchemaValidations:
-    def test_valid_iteration_if_actions_mapper_has_entry_for_the_provided_default_routing_key(self, valid_campaign_config_with_only_mandatory_fields):
+    def test_valid_iteration_if_actions_mapper_has_entry_for_the_provided_default_routing_key(
+        self, valid_campaign_config_with_only_mandatory_fields
+    ):
         expected_action = {
             "ExternalRoutingCode": "BookLocal",
             "ActionDescription": "##Getting the vaccine\n"
-                                 "You can get an RSV vaccination at your GP surgery.\n"
-                                 "Your GP surgery may contact you about getting the RSV vaccine. "
-                                 "This may be by letter, text, phone call, email or through the NHS App. "
-                                 "You do not need to wait to be contacted before booking your vaccination.",
-            "ActionType": "InfoText"
+            "You can get an RSV vaccination at your GP surgery.\n"
+            "Your GP surgery may contact you about getting the RSV vaccine. "
+            "This may be by letter, text, phone call, email or through the NHS App. "
+            "You do not need to wait to be contacted before booking your vaccination.",
+            "ActionType": "InfoText",
         }
 
-        data = {**valid_campaign_config_with_only_mandatory_fields["Iterations"][0],
-                "DefaultCommsRouting": "BOOK_LOCAL", "ActionsMapper": {
-                "BOOK_LOCAL": expected_action
-            }}
+        data = {
+            **valid_campaign_config_with_only_mandatory_fields["Iterations"][0],
+            "DefaultCommsRouting": "BOOK_LOCAL",
+            "ActionsMapper": {"BOOK_LOCAL": expected_action},
+        }
         IterationValidation(**data)
 
-    def test_invalid_iteration_if_actions_mapper_has_no_entry_for_the_provided_default_routing_key(self, valid_campaign_config_with_only_mandatory_fields):
-        data = {**valid_campaign_config_with_only_mandatory_fields["Iterations"][0],
-                "DefaultCommsRouting": "BOOK_LOCAL", "ActionsMapper": {}} # Missing BOOK_LOCAL in ActionsMapper
+    def test_invalid_iteration_if_actions_mapper_has_no_entry_for_the_provided_default_routing_key(
+        self, valid_campaign_config_with_only_mandatory_fields
+    ):
+        data = {
+            **valid_campaign_config_with_only_mandatory_fields["Iterations"][0],
+            "DefaultCommsRouting": "BOOK_LOCAL",
+            "ActionsMapper": {},
+        }  # Missing BOOK_LOCAL in ActionsMapper
 
         with pytest.raises(ValidationError) as error:
             IterationValidation(**data)
 
         errors = error.value.errors()
-        assert any(
-            e["loc"][-1] == "actions_mapper" and "BOOK_LOCAL" in str(e["msg"])
-            for e in errors
-        ), "Expected validation error for missing BOOK_LOCAL entry in ActionsMapper"
-
-
+        assert any(e["loc"][-1] == "actions_mapper" and "BOOK_LOCAL" in str(e["msg"]) for e in errors), (
+            "Expected validation error for missing BOOK_LOCAL entry in ActionsMapper"
+        )