Skip to content

Commit 19f90bf

Browse files
committed
Merge remote-tracking branch 'origin/main' into bugfix/eja-eli-306-adding-kms-decrypt-for-lambda-rules-bucket
2 parents 0f6ebaa + eb08f5e commit 19f90bf

17 files changed

Lines changed: 67 additions & 77 deletions

src/eligibility_signposting_api/repos/person_repo.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def __init__(self, table: Annotated[Any, Inject(qualifier="person_table")]) -> N
3636
self.table = table
3737

3838
def get_eligibility_data(self, nhs_number: NHSNumber) -> list[dict[str, Any]]:
39-
response = self.table.query(KeyConditionExpression=Key("NHS_NUMBER").eq(f"PERSON#{nhs_number}"))
39+
response = self.table.query(KeyConditionExpression=Key("NHS_NUMBER").eq(nhs_number))
4040
logger.debug("response %r for %r", response, nhs_number, extra={"response": response, "nhs_number": nhs_number})
4141

4242
if not (items := response.get("Items")):

tests/e2e/data/dynamoDB/AUTO_RSV_SB_001.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Actionable due to membership of an Age Cohort incl. suggested actions (with booking)",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000001",
5+
"NHS_NUMBER": "PERSON#5000000001",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000001",
15+
"NHS_NUMBER": "PERSON#5000000001",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000001",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000001",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"BOOKED_APPOINTMENT_DATE": "<<DATE_TOMORROW>>",
3736
"BOOKED_APPOINTMENT_PROVIDER": "NBS"
3837
}

tests/e2e/data/dynamoDB/AUTO_RSV_SB_002.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Actionable due to membership of an Age Cohort incl. suggested action (not booking)",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000002",
5+
"NHS_NUMBER": "PERSON#5000000002",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000002",
15+
"NHS_NUMBER": "PERSON#5000000002",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",

tests/e2e/data/dynamoDB/AUTO_RSV_SB_003.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Actionable due to membership of an alternative Age Cohort incl. suggested action",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000003",
5+
"NHS_NUMBER": "PERSON#5000000003",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_age_catchup",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000003",
15+
"NHS_NUMBER": "PERSON#5000000003",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",

tests/e2e/data/dynamoDB/AUTO_RSV_SB_004.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Actionable due to membership of an Age Cohort incl. suggested action (existing national booking)",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000004",
5+
"NHS_NUMBER": "PERSON#5000000004",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000004",
15+
"NHS_NUMBER": "PERSON#5000000004",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000004",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000004",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"BOOKED_APPOINTMENT_DATE": "<<DATE_TOMORROW>>",
3736
"BOOKED_APPOINTMENT_PROVIDER": "NBS"
3837
}

tests/e2e/data/dynamoDB/AUTO_RSV_SB_005.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Actionable due to membership of an Age Cohort incl. suggested actions (with local booking)",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000005",
5+
"NHS_NUMBER": "PERSON#5000000005",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000005",
15+
"NHS_NUMBER": "PERSON#5000000005",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000005",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000005",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"BOOKED_APPOINTMENT_DATE": "<<DATE_TOMORROW>>",
3736
"BOOKED_APPOINTMENT_PROVIDER": "ACC"
3837
}

tests/e2e/data/dynamoDB/AUTO_RSV_SB_006.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Not Actionable despite membership of an Age Cohort, already vaccinated",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000006",
5+
"NHS_NUMBER": "PERSON#5000000006",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000006",
15+
"NHS_NUMBER": "PERSON#5000000006",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000006",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000006",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"LAST_SUCCESSFUL_DATE": "<<DATE_LAST_WEEK>>"
3736
}
3837
]

tests/e2e/data/dynamoDB/AUTO_RSV_SB_007.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Not Actionable, membership of Age Cohort, no available vaccinations (not available type 1)",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000007",
5+
"NHS_NUMBER": "PERSON#5000000007",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000007",
15+
"NHS_NUMBER": "PERSON#5000000007",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000007",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000007",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"LAST_SUCCESSFUL_DATE": "<<DATE_LAST_WEEK>>"
3736
}
3837
]

tests/e2e/data/dynamoDB/AUTO_RSV_SB_008.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - No RSV response as no active campaign (not available type 2)",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000008",
5+
"NHS_NUMBER": "PERSON#5000000008",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000008",
15+
"NHS_NUMBER": "PERSON#5000000008",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000008",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000008",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"BOOKED_APPOINTMENT_DATE": "2024-07-01"
3736
}
3837
]

tests/e2e/data/dynamoDB/AUTO_RSV_SB_009.json

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"scenario_name": "RSV - Not Actionable, membership of Age Cohort, dose not yet due",
33
"data": [
44
{
5-
"NHS_NUMBER": "5000000009",
5+
"NHS_NUMBER": "PERSON#5000000009",
66
"ATTRIBUTE_TYPE": "COHORTS",
77
"COHORT_MEMBERSHIPS": [
88
{
99
"COHORT_LABEL": "rsv_75_rolling",
10-
"DATE_JOINED": "2025-01-01"
10+
"DATE_JOINED": "20250101"
1111
}
1212
]
1313
},
1414
{
15-
"NHS_NUMBER": "5000000009",
15+
"NHS_NUMBER": "PERSON#5000000009",
1616
"ATTRIBUTE_TYPE": "PERSON",
1717
"DATE_OF_BIRTH": "<<DATE_AGE_75>>",
1818
"GENDER": "0",
@@ -30,9 +30,8 @@
3030
"DE_FLAG": "N"
3131
},
3232
{
33-
"NHS_NUMBER": "5000000009",
34-
"ATTRIBUTE_TYPE": "TARGET",
35-
"TYPE": "RSV",
33+
"NHS_NUMBER": "PERSON#5000000009",
34+
"ATTRIBUTE_TYPE": "RSV",
3635
"LAST_SUCCESSFUL_DATE": "2023-07-01"
3736
}
3837
]

0 commit comments

Comments
 (0)