[ELI-702] - changing name to something valid

Author: TOEL2

infrastructure/modules/lambda/signing.tf

@@ -1,5 +1,6 @@
 resource "aws_signer_signing_profile" "lambda_signing" {
-  name_prefix = "eligibility-signing-"
+  name = "eligibilityapi${var.environment}lambdasigningprofile"
+  #aws signer is strict with names, does not like hyphens or underscores
 
   platform_id = "AWSLambda-SHA384-ECDSA"