Merge pull request #228 from NHSDigital/bugfix/eja-deduplicate-policy-naming

eddalmond1 · web-flow · commit 2e8f19d32f2b · 2025-07-10T15:14:09.000+01:00
bugfix - deduplicating a policy name as causing issues with overwriti…
diff --git a/infrastructure/modules/s3/s3.tf b/infrastructure/modules/s3/s3.tf
@@ -16,7 +16,7 @@ resource "aws_s3_bucket_versioning" "storage_bucket_versioning_config" {
 
 # ensure only secure transport is allowed
 
-resource "aws_s3_bucket_policy" "tfstate_bucket" {
+resource "aws_s3_bucket_policy" "storage_bucket" {
   bucket = aws_s3_bucket.storage_bucket.id
   policy = data.aws_iam_policy_document.storage_s3_bucket_policy.json
 }

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ resource "aws_s3_bucket_versioning" "storage_bucket_versioning_config" {`
`16`	`16`
`17`	`17`	`# ensure only secure transport is allowed`
`18`	`18`
`19`		`-resource "aws_s3_bucket_policy" "tfstate_bucket" {`
	`19`	`+resource "aws_s3_bucket_policy" "storage_bucket" {`
`20`	`20`	`bucket = aws_s3_bucket.storage_bucket.id`
`21`	`21`	`policy = data.aws_iam_policy_document.storage_s3_bucket_policy.json`
`22`	`22`	`}`