changed cloudwatch access log bucket name to meet character requirements (#626)

* changed cloudwatch access log bucket name to meet character requirements

* shortened cloudwatch bucket name

Author: oneeb-nhs

infrastructure/stacks/api-layer/s3_buckets.tf

@@ -60,7 +60,7 @@ module "s3_dq_metrics_bucket" {
 
 module "s3_cloudtrail_bucket" {
   source       = "../../modules/s3"
-  bucket_name  = "eli-cloudwatch-logs"
+  bucket_name  = "eli-cloudwatch"
   environment  = var.environment
   project_name = var.project_name
   stack_name   = local.stack_name

infrastructure/stacks/iams-developer-roles/github_actions_policies.tf

@@ -235,10 +235,10 @@ resource "aws_iam_policy" "s3_management" {
           "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-dq-metrics/*",
           "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-dq-metrics-access-logs",
           "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-dq-metrics-access-logs/*",
-          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs",
-          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs/*",
-          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs-access-logs",
-          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-logs-access-logs/*",
+          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch",
+          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch/*",
+          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-access-logs",
+          "arn:aws:s3:::*eligibility-signposting-api-${var.environment}-eli-cloudwatch-access-logs/*",
         ]
       }
     ]