Merge pull request #151 from NHSDigital/test/empty_description_cases

test/cohort group descriptions pick first non empty

Author: robbailiff2

tests/unit/services/calculators/test_eligibility_calculator.py

@@ -1443,6 +1443,13 @@ def test_cohort_group_descriptions_are_selected_based_on_priority_when_cohorts_h
             Status.not_eligible,
             "if group has one cohort, with no description, expect no description",
         ),
+        (
+            person_rows_builder("123", postcode="SW19", cohorts=["rsv_75to79_2024", "rsv_75_rolling"], de=False),
+            [rule_builder.Rsv75to79CohortFactory.build(negative_description=None, priority=2)],
+            [("rsv_age_range", "")],
+            Status.not_eligible,
+            "if group has one cohort, with no description, expect no description",
+        ),
         (
             person_rows_builder("123", postcode="HP1", cohorts=["rsv_75to79_2024", "rsv_75_rolling"], de=True),
             [rule_builder.Rsv75to79CohortFactory.build(positive_description=None, priority=2)],
@@ -1470,6 +1477,19 @@ def test_cohort_group_descriptions_are_selected_based_on_priority_when_cohorts_h
             Status.not_eligible,
             "if group has more than one cohort, at least one has description, expect first non empty description",
         ),
+        (
+            person_rows_builder("123", postcode="SW19", cohorts=["rsv_75to79_2024", "rsv_75_rolling"], de=False),
+            [
+                rule_builder.Rsv75to79CohortFactory.build(priority=2, negative_description=None),
+                rule_builder.Rsv75RollingCohortFactory.build(priority=3, negative_description="rsv age range -ve 1"),
+                rule_builder.Rsv75RollingCohortFactory.build(
+                    cohort_label="rsv_75_rolling_2", priority=4, negative_description="rsv age range -ve 2"
+                ),
+            ],
+            [("rsv_age_range", "rsv age range -ve 1")],
+            Status.not_eligible,
+            "if group has more than one cohort, at least one has description, expect first non empty description",
+        ),
         (
             person_rows_builder("123", postcode="HP1", cohorts=["rsv_75to79_2024", "rsv_75_rolling"], de=True),
             [