extracting method for readability

Author: TOEL2

src/eligibility_signposting_api/services/processors/rule_processor.py

@@ -82,20 +82,11 @@ def is_actionable(
 
         for _, rule_group in groupby(sorted_rules_by_priority, key=priority_getter):
             group_rules = list(rule_group)
-            cohort_specific_rules = [rule for rule in group_rules if rule.cohort_label is not None]
-            matching_specific_rules = [
-                rule for rule in cohort_specific_rules if rule.cohort_label == cohort.cohort_label
-            ]
-            if cohort_specific_rules and not matching_specific_rules:
-                continue
-
-            applicable_rules = list(self.get_exclusion_rules(cohort, group_rules))
-
-            if not applicable_rules:
+            if self._should_skip_rule_group(cohort, group_rules):
                 continue
 
             status, group_exclusion_reasons, rule_stop = self.evaluate_rules_priority_group(
-                person, iter(applicable_rules)
+                person, iter(group_rules)
             )
             if status.is_exclusion:
                 is_actionable = False
@@ -118,6 +109,14 @@ def is_actionable(
                     suppression_reasons,
                 )
 
+    @staticmethod
+    def _should_skip_rule_group(cohort: IterationCohort, group_rules: list[IterationRule]) -> bool:
+        cohort_specific_rules = [rule for rule in group_rules if rule.cohort_label is not None]
+        matching_specific_rules = [
+            rule for rule in cohort_specific_rules if rule.cohort_label == cohort.cohort_label
+        ]
+        return bool(cohort_specific_rules and not matching_specific_rules)
+
     def evaluate_rules_priority_group(
         self, person: Person, rules_group: Iterator[IterationRule]
     ) -> tuple[eligibility_status.Status, list[eligibility_status.Reason], bool]:

tests/unit/services/processors/test_rule_processor.py

@@ -153,12 +153,13 @@ def test_general_rule_should_not_evaluate_in_isolation_without_matching_specific
     cohort = rule_builder.IterationCohortFactory.build(cohort_label="COHORT_B", positive_description="Eligible")
     cohort_results = {}
 
-    # Rule 1: cohort-specific to COHORT_A — should be filtered out
+    # Rule 1: Non-matching rule cohort-specific to COHORT_A — should not be evaluated
     rule_specific = rule_builder.IterationRuleFactory.build(
         priority=510, type=RuleType.suppression, cohort_label="COHORT_A", name="SPECIFIC_RULE"
     )
 
-    # Rule 2: General rule
+    # Rule 2: Matching general rule of the same priority as cohort-specific rule
+    # - should also not be evaluated
     rule_general = rule_builder.IterationRuleFactory.build(
         priority=510, type=RuleType.suppression, cohort_label=None, name="GENERAL_RULE"
     )
@@ -168,9 +169,8 @@ def test_general_rule_should_not_evaluate_in_isolation_without_matching_specific
     # Act
     rule_processor.is_actionable(MOCK_PERSON_DATA, cohort, cohort_results, suppression_rules)
 
-    # ❌ BUG: General rule should not be evaluated in isolation.
+    # None of the rules should be evaluated
     mock_evaluate_rules_priority_group.assert_not_called()
-
     # Cohort remains actionable
     assert_that(cohort_results["COHORT_B"].status, is_(Status.actionable))