Resolving copilot code smells

Author: Sambit Kumar Mishra

src/rules_validation_api/validators/iteration_validator.py

@@ -100,16 +100,26 @@ def transform_actions_mapper(cls, action_mapper: ActionsMapper) -> ActionsMapper
     @model_validator(mode="after")
     def validate_rule_cohort_labels_against_iteration_cohorts(self) -> typing.Self:
         allowed_labels = {cohort.cohort_label for cohort in self.iteration_cohorts}
+        line_errors: list[InitErrorDetails] = []
 
         for idx, rule in enumerate(self.iteration_rules):
             if rule.cohort_label is None:
                 continue
-            if not all(label in allowed_labels for label in rule.parsed_cohort_labels):
-                allowed_str = ", ".join(sorted(allowed_labels))
-                msg = (
-                    f"Invalid cohort_label value: {rule.cohort_label}. Allowed values: {allowed_str}. Rule index: {idx}"
-                )
-                raise ValueError(msg)
+
+            for label in rule.parsed_cohort_labels:
+                if label not in allowed_labels:
+                    allowed_str = ", ".join(sorted(allowed_labels))
+                    error = InitErrorDetails(
+                        type="value_error",
+                        loc=("iteration_rules", idx, "cohort_label"),
+                        input=rule.cohort_label,
+                        ctx={
+                            "error": f"Invalid cohort_label value '{label}'. Allowed values: {allowed_str}."
+                        },
+                    )
+                    line_errors.append(error)
+        if line_errors:
+            raise ValidationError.from_exception_data(title="IterationValidation", line_errors=line_errors)
 
         return self
 

tests/unit/validation/test_iteration_validator.py

@@ -579,5 +579,12 @@ def test_iteration_rules_having_invalid_cohort_labels_throws_error(
         data["IterationCohorts"] = [valid_iteration_cohorts()]
         data["IterationRules"][0]["CohortLabel"] = "label_2"
 
-        with pytest.raises(ValidationError):
-            IterationValidation(**(data))
+        with pytest.raises(ValidationError) as exc_info:
+            IterationValidation(**data)
+
+        errors = exc_info.value.errors()
+        # Ensure at least one error is specifically about the invalid CohortLabel in IterationRules[0]
+        assert any(
+            err.get("loc", [])[:3] == ("iteration_rules", 0, "cohort_label")
+            for err in errors
+        )