[ELI-619] - switching from a list to a prefix

Author: TOEL2

src/eligibility_signposting_api/config/constants.py

@@ -7,6 +7,5 @@
 CONSUMER_ID = "NHSE-Product-ID"
 ALLOWED_CONDITIONS = Literal["COVID", "FLU", "MMR", "RSV"]
 CONSUMER_MAPPING_FILE_NAME = "consumer_mapping_config.json"
-RESERVED_TEST_CONSUMER_IDS = {"test-consumer-1", "test-consumer-2", "test-consumer-3"}
 
 CACHE_TTL_SECONDS = int(os.getenv("CONFIG_CACHE_TTL_SECONDS", "1800"))

src/eligibility_signposting_api/repos/campaign_repo.py

@@ -11,7 +11,7 @@
 from wireup import Inject, service
 
 from eligibility_signposting_api.model.campaign_config import CampaignConfig, Rules
-from eligibility_signposting_api.config.constants import CACHE_TTL_SECONDS, RESERVED_TEST_CONSUMER_IDS
+from eligibility_signposting_api.config.constants import CACHE_TTL_SECONDS
 
 BucketName = NewType("BucketName", str)
 
@@ -35,7 +35,7 @@ def __init__(
         self.bucket_name = bucket_name
 
     def get_campaign_configs(self, consumer_id: str) -> Generator[CampaignConfig, None, None]:
-        bypass = consumer_id in RESERVED_TEST_CONSUMER_IDS
+        bypass = "test-" in consumer_id
         cache_key = "all_campaigns"
         cached = None if bypass else campaign_config_cache.get(cache_key)
 

tests/integration/conftest.py

@@ -1247,7 +1247,7 @@ def campaign_configs(request, s3_client: BaseClient, rules_bucket: BucketName) -
 
 @pytest.fixture(scope="class")
 def consumer_id() -> ConsumerId:
-    return ConsumerId("23-mic7heal-jor6don")
+    return ConsumerId("test-23-mic7heal-jor6don")
 
 
 def create_and_put_consumer_mapping_in_s3(