Changes for ELI-595

Author: Sambit Kumar Mishra

src/rules_validation_api/validators/iteration_validator.py

@@ -97,6 +97,27 @@ def transform_actions_mapper(cls, action_mapper: ActionsMapper) -> ActionsMapper
         action_mapper.root = new_root
         return action_mapper
 
+    @model_validator(mode="after")
+    def validate_rule_cohort_labels_against_iteration_cohorts(self) -> typing.Self:
+        allowed_labels = {cohort.cohort_label for cohort in self.iteration_cohorts}
+        print(allowed_labels)
+
+        for idx, rule in enumerate(self.iteration_rules):
+            if rule.cohort_label is None:
+                continue
+            print("parsed cohort labels from rules:")
+            print(rule.parsed_cohort_labels)
+            if not all(label in allowed_labels for label in rule.parsed_cohort_labels):
+                allowed_str = ", ".join(sorted(allowed_labels))
+                msg = (
+                    f"Invalid cohort_label value: {rule.cohort_label}. "
+                    f"Allowed values: {allowed_str}. "
+                    f"Rule index: {idx}"
+                )
+                raise ValueError(msg)
+
+        return self
+
     @model_validator(mode="after")
     def action_mapper_validation(self) -> typing.Self:
         all_errors = []

tests/unit/validation/test_iteration_validator.py

@@ -570,3 +570,19 @@ def test_iteration_full_datetime_validation(  # noqa : PLR0913
             f"Failed! Input: {iteration_time_input}, Default: {default_time_iteration_input}. "
             f"Expected {expected_date_time} but got {result}"
         )
+
+    def test_iteration_rules_having_invalid_cohort_labels_throws_error(
+        self, valid_iteration_with_only_mandatory_fields,
+        valid_iteration_rule_with_only_mandatory_fields,
+        valid_iteration_cohorts,
+    ):
+        data = valid_iteration_with_only_mandatory_fields.copy()
+        data["iteration_rules"] = [valid_iteration_rule_with_only_mandatory_fields]
+        data["iteration_cohorts"] = [valid_iteration_cohorts]
+        data["iteration_rules"][0]["CohortLabel"] = "label_2"
+        IterationValidation(**(data))
+        # try:
+
+        #     IterationValidation(**(data))
+        # except ValidationError as e:
+        #     pytest.fail(f"Unexpected error during model instantiation: {e}")