wip with failing tests

Author: Karthikeyannhs

src/rules_validation_api/validators/campaign_config_validator.py

@@ -1,4 +1,5 @@
-from pydantic import Field, field_validator
+from pydantic import Field, field_validator, model_validator, ValidationError
+from pydantic_core import PydanticCustomError, InitErrorDetails
 
 from eligibility_signposting_api.model.campaign_config import CampaignConfig
 from rules_validation_api.validators.iteration_validator import IterationValidation
@@ -13,9 +14,29 @@ def validate_name(cls, value: str) -> str:
             raise ValueError("campaign ID must not be empty")
         return value
 
-    @field_validator("type")
-    def validate_type(cls, value: str) -> str:
-        allowed_values = {"V", "S"}
-        if value not in allowed_values:
-            raise ValueError(f"type must be one of {allowed_values}")
-        return value
+    @model_validator(mode="before")
+    def validate_default_comms_routing_in_actions_mapper(cls, values):
+        iterations = values.get("Iterations") or values.get("iterations")
+        if not iterations:
+            return values
+
+        error_list = []
+
+        for i, iter_data in enumerate(iterations):
+            default_routing = iter_data.get("DefaultCommsRouting")
+            actions_mapper = iter_data.get("ActionsMapper", {})
+
+            if default_routing and default_routing not in actions_mapper:
+                error_list.append(
+                    InitErrorDetails(
+                        loc=("Iterations", i, "ActionsMapper"),
+                        msg=f"Missing key '{default_routing}' in ActionsMapper",
+                        input=actions_mapper,
+                        type="value_error.missing_actions_mapper_entry"
+                    )
+                )
+
+        if error_list:
+            raise ValidationError(error_list, cls)
+
+        return values

tests/unit/validation/test_campaign_config_validator.py

@@ -233,3 +233,39 @@ def test_validate_iterations_non_empty(self, valid_campaign_config_with_only_man
             CampaignConfigValidation(**data)
         errors = error.value.errors()
         assert any(e["loc"][-1] == "Iterations" for e in errors), "Expected validation error on 'Iterations'"
+
+    def test_actions_mapper_has_default_comms_routing_key(self, valid_campaign_config_with_only_mandatory_fields):
+        expected_action = {
+            "ExternalRoutingCode": "BookLocal",
+            "ActionDescription": "##Getting the vaccine\n"
+                                 "You can get an RSV vaccination at your GP surgery.\n"
+                                 "Your GP surgery may contact you about getting the RSV vaccine. "
+                                 "This may be by letter, text, phone call, email or through the NHS App. "
+                                 "You do not need to wait to be contacted before booking your vaccination.",
+            "ActionType": "InfoText"
+        }
+
+        config = {**valid_campaign_config_with_only_mandatory_fields}
+        config["Iterations"][0]["DefaultCommsRouting"] = "BOOK_LOCAL"
+        config["Iterations"][0]["ActionsMapper"] = {
+            "BOOK_LOCAL": expected_action
+        }
+
+        # Should not raise error
+        CampaignConfigValidation(**config)
+
+    def test_actions_mapper_missing_default_comms_routing_key(self, valid_campaign_config_with_only_mandatory_fields):
+        config = {**valid_campaign_config_with_only_mandatory_fields}
+        config["Iterations"][0]["DefaultCommsRouting"] = "BOOK_LOCAL"
+        config["Iterations"][0]["ActionsMapper"] = {}  # Missing BOOK_LOCAL
+
+        with pytest.raises(ValidationError) as error:
+            CampaignConfigValidation(**config)
+
+        errors = error.value.errors()
+        assert any(
+            e["loc"][-1] == "ActionsMapper" and "BOOK_LOCAL" in str(e["msg"])
+            for e in errors
+        ), "Expected validation error for missing BOOK_LOCAL entry in ActionsMapper"
+
+