path validation fixed

Author: Karthikeyannhs

src/eligibility_signposting_api/common/request_validator.py

@@ -40,10 +40,6 @@ def validate_query_params(query_params: dict[str, str]) -> tuple[bool, ResponseR
 
 
 def validate_nhs_number_in_header(path_nhs: str | None, header_nhs: str | None) -> bool:
-    if not path_nhs:
-        logger.error("NHS number is not present in path", extra={"header_nhs": header_nhs, "path_nhs": path_nhs})
-        return False
-
     if header_nhs != path_nhs:
         logger.error("NHS number mismatch", extra={"header_nhs": header_nhs, "path_nhs": path_nhs})
         return False

tests/unit/common/test_request_validator.py

@@ -20,8 +20,6 @@ class TestValidateNHSNumber:
     @pytest.mark.parametrize(
         ("path_nhs", "header_nhs", "expected_result", "expected_log_msg"),
         [
-            (None, None, False, "NHS number is not present in path"),
-            (None, "1234567890", False, "NHS number is not present in path"),
             ("1234567890", None, False, "NHS number mismatch"),
             ("1234567890", "", False, "NHS number mismatch"),
             ("1234567890", "0987654321", False, "NHS number mismatch"),