added comments

Author: Karthikeyannhs

src/eligibility_signposting_api/common/request_validator.py

@@ -10,9 +10,9 @@
     INVALID_CATEGORY_ERROR,
     INVALID_CONDITION_FORMAT_ERROR,
     INVALID_INCLUDE_ACTIONS_ERROR,
-    NHS_NUMBER_ERROR,
+    NHS_NUMBER_ERROR, CONSUMER_ID_NOT_PROVIDED_ERROR,
 )
-from eligibility_signposting_api.config.constants import NHS_NUMBER_HEADER
+from eligibility_signposting_api.config.constants import NHS_NUMBER_HEADER, CONSUMER_ID
 
 logger = logging.getLogger(__name__)
 
@@ -50,6 +50,14 @@ def validate_request_params() -> Callable:
     def decorator(func: Callable) -> Callable:
         @wraps(func)
         def wrapper(*args, **kwargs) -> ResponseReturnValue:  # noqa:ANN002,ANN003
+
+            consumer_id = request.headers.get(CONSUMER_ID)
+            if not consumer_id:
+                message = "You are not authorised to request"
+                return CONSUMER_ID_NOT_PROVIDED_ERROR.log_and_generate_response(
+                    log_message=message, diagnostics=message
+                )
+
             path_nhs_number = str(kwargs.get("nhs_number")) if kwargs.get("nhs_number") else None
 
             if not path_nhs_number:

tests/integration/in_process/test_eligibility_endpoint.py

@@ -1161,6 +1161,7 @@ def test_valid_response_when_consumer_has_a_valid_campaign_config_mapping(  # no
     @pytest.mark.parametrize(
         ("consumer_id", "expected_campaign_id"),
         [
+            #Consumer requesting for ALL
             # Consumer is mapped only to RSV_campaign_id_1
             ("consumer-id-1", "RSV_campaign_id_1"),
             # Consumer  is mapped only to RSV_campaign_id_2
@@ -1180,6 +1181,7 @@ def test_valid_response_when_consumer_has_a_valid_campaign_config_mapping(  # no
         [
             (
                 [
+                    # Campaign configs in S3
                     ("RSV", "RSV_campaign_id_1"),
                     ("RSV", "RSV_campaign_id_2"),
                     ("RSV", "RSV_campaign_id_3"),
@@ -1188,6 +1190,7 @@ def test_valid_response_when_consumer_has_a_valid_campaign_config_mapping(  # no
                     ("RSV", "RSV_campaign_id_6"),
                 ],
                 {
+                    # Consumer mappings in S3
                     "consumer-id-1": [{"Campaign": "RSV_campaign_id_1"}],
                     "consumer-id-2": [{"Campaign": "RSV_campaign_id_2"}],
                     "consumer-id-3a": [{"Campaign": "RSV_campaign_id_3"}, {"Campaign": "RSV_campaign_id_4"}],