wip-3

Author: Karthikeyannhs

src/eligibility_signposting_api/services/calculators/eligibility_calculator.py

@@ -11,7 +11,7 @@
 from wireup import service
 
 from eligibility_signposting_api.model import eligibility, rules
-from eligibility_signposting_api.model.eligibility import Status, CohortStatus
+from eligibility_signposting_api.model.eligibility import Status, CohortStatus, Condition, ConditionName
 from eligibility_signposting_api.services.calculators.rule_calculator import RuleCalculator
 
 Row = Collection[Mapping[str, Any]]
@@ -86,7 +86,7 @@ def get_best_cohort(
     def evaluate_eligibility(self):
         """Iterates over campaign groups, evaluates eligibility, and returns a consolidated status."""
         priority_getter = attrgetter("priority")
-        results: dict[str, tuple[Status, list[CohortStatus]]] = defaultdict()
+        results: dict[ConditionName, tuple[Status, list[CohortStatus]]] = defaultdict()
         for condition_name, campaign_group in self.campaigns_grouped_by_condition_name:
             iteration_results: dict[str, tuple[Status, list[CohortStatus]]] = defaultdict()
             for active_iteration in [cc.current_iteration for cc in campaign_group]:
@@ -138,12 +138,18 @@ def evaluate_eligibility(self):
             for name, iteration_result in iteration_results.items():
                 if iteration_result[0] is best_so_far:
                     results[condition_name] = iteration_result
-                    break
+                    break # if the status is the same, we can break out of the loop - we are picking the first one
         # Consolidate all the results and return
-        # TODO
-        #results: dict[str, tuple[Status, list[CohortStatus]]] = defaultdict()
+        final_result = [
+            Condition(
+                condition_name=condition_name,
+                status=status,
+                reasons=sum((cohort.reasons for cohort in cohort_status_list), [])
+            )
+            for condition_name, (status, cohort_status_list) in results.items()
+        ]
 
-        return eligibility.EligibilityStatus(conditions=list(self.results))
+        return eligibility.EligibilityStatus(conditions=final_result)
 
     def get_the_base_eligible_campaigns(self, campaign_group: list[rules.CampaignConfig]) -> list[rules.CampaignConfig]:
         """Return campaigns for which the person is base eligible via cohorts."""