Fixed TODOs

Author: shweta-nhs

src/eligibility_signposting_api/audit_models.py

@@ -1,5 +1,5 @@
 from dataclasses import dataclass, field
-from datetime import datetime, UTC
+from datetime import UTC, datetime
 from uuid import UUID
 
 

src/eligibility_signposting_api/services/calculators/eligibility_calculator.py

@@ -199,6 +199,7 @@ def evaluate_eligibility(self, *, include_actions_flag: bool = True) -> eligibil
 
             # add actions to condition results
             condition_results[condition_name].actions = actions
+            # reset actions for the next condition
             actions: SuggestedActions | None = SuggestedActions([])
 
             # add audit data
@@ -256,7 +257,7 @@ def get_cohort_results(self, active_iteration: rules.Iteration) -> dict[str, Coh
             # Not base eligible
             elif cohort.cohort_label is not None:
                 cohort_results[cohort.cohort_label] = CohortGroupResult(
-                    (cohort.cohort_group),
+                    cohort.cohort_group,
                     Status.not_eligible,
                     [],
                     cohort.negative_description,

src/eligibility_signposting_api/views/eligibility.py

@@ -49,9 +49,7 @@ def check_eligibility(
         return handle_unknown_person_error(nhs_number)
     else:
         eligibility_response = build_eligibility_response(eligibility_status)
-
         AuditContext.write_to_firehose(audit_service, eligibility_response)
-
         return make_response(
             eligibility_response.model_dump(by_alias=True, mode="json", exclude_none=True), HTTPStatus.OK
         )

tests/unit/test_audit_context.py

@@ -33,8 +33,7 @@
 
 @pytest.fixture
 def app():
-    app = Flask(__name__)
-    return app
+    return Flask(__name__)
 
 
 def test_add_request_details_sets_audit_log_on_g(app):
@@ -141,9 +140,11 @@ def test_append_audit_condition_adds_condition_to_audit_log_on_g(app):
         assert cond.status_text == best_results[1].status.name
 
 
-def test_add_response_details_adds_to_audit_log_on_G(app):
+def test_add_response_details_adds_to_audit_log_on_g(app):
     eligibility_response = EligibilityResponseFactory.build(
-        response_id=uuid.uuid4(), meta={"last_updated": datetime(2023, 1, 1, 0, 0)}, processed_suggestions=[]
+        response_id=uuid.uuid4(),
+        meta={"last_updated": datetime(2023, 1, 1, 0, 0, tzinfo=UTC)},
+        processed_suggestions=[],
     )
 
     with app.app_context():