linting fixes

Author: Karthikeyannhs

src/eligibility_signposting_api/logging/logs_manager.py

@@ -30,9 +30,14 @@ def wrapper(event: LambdaEvent, context: LambdaContext) -> dict[str, Any] | None
 
 
 class EnrichedJsonFormatter(JsonFormatter):
-    def add_fields(self, log_data: dict[str, Any], record: logging.LogRecord, message_dict: dict[str, Any]) -> None:
-        log_data["request_id"] = request_id_context_var.get() or "-"
-        super().add_fields(log_data, record, message_dict)
+    def add_fields(
+        self,
+        log_record: dict[str, Any],
+        record: logging.LogRecord,
+        message_dict: dict[str, Any],
+    ) -> None:
+        log_record["request_id"] = request_id_context_var.get() or "-"
+        super().add_fields(log_record, record, message_dict)
 
 
 def init_logging(quieten: Sequence[str] = ("asyncio", "botocore", "boto3", "mangum", "urllib3")) -> None:

src/eligibility_signposting_api/model/campaign_config.py

@@ -158,7 +158,7 @@ class IterationRule(BaseModel):
     model_config = {"populate_by_name": True, "extra": "ignore"}
 
     @field_validator("rule_stop", mode="before")
-    def parse_yn_to_bool(cls, v: str | bool) -> bool:  # noqa: N805, FBT001
+    def parse_yn_to_bool(cls, v: str | bool) -> bool:  # noqa: N805
         if isinstance(v, str):
             return v.upper() == "Y"
         return v

src/rules_validation_api/app.py

@@ -51,7 +51,8 @@ def main() -> None:
             json_data = json.load(file)
             result = RulesValidation(**json_data)
             sys.stdout.write(f"{GREEN}Valid Config{RESET}\n")
-            sys.stdout.write(f"{COLON_COLOR}Current Iteration Number is {RESET}{RIGHT_COLOR}"
+            sys.stdout.write(
+                f"{COLON_COLOR}Current Iteration Number is {RESET}{RIGHT_COLOR}"
                 f"{result.campaign_config.current_iteration.iteration_number}{RESET}\n"
             )
 

tests/integration/conftest.py

@@ -228,7 +228,7 @@ def iam_role(iam_client: BaseClient) -> Generator[str]:
 
 @pytest.fixture(scope="session")
 def lambda_zip() -> Path:
-    build_result = subprocess.run(["make", "build"], capture_output=True, text=True, check=False)  # noqa: S607
+    build_result = subprocess.run(["make", "build"], capture_output=True, text=True, check=False)  # noqa: S603, S607
     assert build_result.returncode == 0, f"'make build' failed: {build_result.stderr}"
     return Path("dist/lambda.zip")