Skip to content

Commit adc998b

Browse files
revoked custom formatter and reapplied JsonFormatter
1 parent bdf24ee commit adc998b

1 file changed

Lines changed: 11 additions & 10 deletions

File tree

  • src/eligibility_signposting_api/config

src/eligibility_signposting_api/config/config.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from functools import cache
55
from typing import Any, NewType
66

7+
from pythonjsonlogger.json import JsonFormatter
78
from yarl import URL
89

910
from eligibility_signposting_api.contextvars_manager import request_id_var
@@ -59,21 +60,21 @@ def config() -> dict[str, Any]:
5960
}
6061

6162

62-
class LoggingJsonFormatter(logging.Formatter):
63-
def format(self, record: logging.LogRecord) -> str:
64-
# Insert request_id from contextvar for every log record
65-
record.request_id = request_id_var.get() or "-"
66-
return super().format(record)
63+
class EnrichedJsonFormatter(JsonFormatter):
64+
def add_fields(self, log_record: dict[str, Any], record: logging.LogRecord, message_dict: dict[str, Any]) -> None:
65+
super().add_fields(log_record, record, message_dict)
66+
log_record["request_id"] = request_id_var.get() or "-"
6767

6868

6969
def init_logging(quieten: Sequence[str] = ("asyncio", "botocore", "boto3", "mangum", "urllib3")) -> None:
70-
log_format = "%(asctime)s %(levelname)-8s %(name)s %(module)s.py:%(funcName)s():%(lineno)d %(message)s"
71-
formatter = LoggingJsonFormatter(log_format)
70+
log_format = "%(asctime)s %(levelname)s %(name)s %(module)s %(funcName)s %(lineno)d %(message)s"
71+
formatter = EnrichedJsonFormatter(log_format)
7272
handler = logging.StreamHandler()
7373
handler.setFormatter(formatter)
74-
logging.root.handlers = [] # Clear any existing handlers
75-
logging.root.setLevel(LOG_LEVEL) # Set log level
76-
logging.root.addHandler(handler) # Add handler
74+
75+
logging.root.handlers = [] # Remove default handlers
76+
logging.root.setLevel(LOG_LEVEL)
77+
logging.root.addHandler(handler)
7778

7879
for q in quieten:
7980
logging.getLogger(q).setLevel(logging.WARNING)

0 commit comments

Comments
 (0)