Merge pull request #120 from NHSDigital/feature/eja-eli-239-amend-terraform-asset-names

eddalmond1 · web-flow · commit c803d5474739 · 2025-06-03T16:53:20.000+01:00
eli-239 fixing terraform role attachment
diff --git a/infrastructure/stacks/api-layer/iam_policies.tf b/infrastructure/stacks/api-layer/iam_policies.tf
@@ -23,8 +23,9 @@ data "aws_iam_policy_document" "dynamodb_write_policy_doc" {
 
 # Attach dynamoDB write policy to external write role
 resource "aws_iam_role_policy" "external_dynamodb_write_policy" {
+  count  = length(aws_iam_role.write_access_role)
   name   = "DynamoDBWriteAccess"
-  role   = aws_iam_role.write_access_role.id
+  role   = aws_iam_role.write_access_role[count.index].id
   policy = data.aws_iam_policy_document.dynamodb_write_policy_doc.json
 }
 
@@ -160,5 +161,3 @@ resource "aws_kms_key_policy" "kms_key" {
   key_id = module.eligibility_status_table.dynamodb_kms_key_id
   policy = data.aws_iam_policy_document.kms_key_policy.json
 }
-
-

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,9 @@ data "aws_iam_policy_document" "dynamodb_write_policy_doc" {`
`23`	`23`
`24`	`24`	`# Attach dynamoDB write policy to external write role`
`25`	`25`	`resource "aws_iam_role_policy" "external_dynamodb_write_policy" {`
	`26`	`+ count = length(aws_iam_role.write_access_role)`
`26`	`27`	`name = "DynamoDBWriteAccess"`
`27`		`- role = aws_iam_role.write_access_role.id`
	`28`	`+ role = aws_iam_role.write_access_role[count.index].id`
`28`	`29`	`policy = data.aws_iam_policy_document.dynamodb_write_policy_doc.json`
`29`	`30`	`}`
`30`	`31`
`@@ -160,5 +161,3 @@ resource "aws_kms_key_policy" "kms_key" {`
`160`	`161`	`key_id = module.eligibility_status_table.dynamodb_kms_key_id`
`161`	`162`	`policy = data.aws_iam_policy_document.kms_key_policy.json`
`162`	`163`	`}`
`163`		`-`
`164`		`-`