eli 623 - nhse-product-id re-cased

Author: Karthikeyannhs

infrastructure/stacks/api-layer/api_gateway.tf

@@ -64,7 +64,6 @@ resource "aws_api_gateway_stage" "eligibility-signposting-api" {
                         "caller": "$context.identity.caller",
                         "httpMethod": "$context.httpMethod",
                         "ip": "$context.identity.sourceIp",
-                        "nhse_product_id": "$context.request.header.nhse-product-id",
                         "protocol": "$context.protocol",
                         "requestId": "$context.requestId",
                         "requestTime": "$context.requestTime",

src/eligibility_signposting_api/config/constants.py

@@ -3,5 +3,5 @@
 URL_PREFIX = "patient-check"
 RULE_STOP_DEFAULT = False
 NHS_NUMBER_HEADER = "nhs-login-nhs-number"
-CONSUMER_ID = "nhse-product-id"  # "NHSE-Product-ID"
+CONSUMER_ID = "NHSE-Product-ID"
 ALLOWED_CONDITIONS = Literal["COVID", "FLU", "MMR", "RSV"]

src/eligibility_signposting_api/logging/logs_helper.py

@@ -5,6 +5,8 @@
 
 from mangum.types import LambdaContext, LambdaEvent
 
+from eligibility_signposting_api.config.constants import CONSUMER_ID
+
 logger = logging.getLogger(__name__)
 
 
@@ -20,7 +22,7 @@ def wrapper(event: LambdaEvent, context: LambdaContext) -> dict[str, Any] | None
                     "x_request_id": headers.get("X-Request-ID"),
                     "x_correlation_id": headers.get("X-Correlation-ID"),
                     "gateway_request_id": gateway_request_id,
-                    "nhse_product_id": headers.get("nhse-product-id"),
+                    "nhse_product_id": headers.get(CONSUMER_ID),
                     "nhsd_application_id": headers.get("nhsd-application-id"),
                 },
             )

tests/integration/lambda/test_app_running_as_lambda.py

@@ -208,7 +208,7 @@ def test_given_nhs_number_in_path_matches_with_nhs_number_in_headers_and_check_i
             "x_correlation_id": "x_correlation_id",
             "nhsd_end_user_organisation_ods": "nhsd_end_user_organisation_ods",
             "nhsd-application-id": "nhsd-application-id",
-            "nhse-product-id": consumer_id,
+            "NHSE-Product-ID": consumer_id,
         },
         params={"includeActions": "Y"},
         timeout=10,
@@ -458,7 +458,7 @@ def test_given_person_has_unique_status_for_different_conditions_with_audit(  #
             "x_correlation_id": "x_correlation_id",
             "nhsd_end_user_organisation_ods": "nhsd_end_user_organisation_ods",
             "nhsd-application-id": "nhsd-application-id",
-            "nhse-product-id": consumer_id,
+            "NHSE-Product-ID": consumer_id,
         },
         params={"includeActions": "Y", "category": "VACCINATIONS", "conditions": "COVID,FLU,RSV"},
         timeout=10,
@@ -602,7 +602,7 @@ def test_no_active_iteration_returns_empty_processed_suggestions(
             "x_correlation_id": "x_correlation_id",
             "nhsd_end_user_organisation_ods": "nhsd_end_user_organisation_ods",
             "nhsd-application-id": "nhsd-application-id",
-            "nhse-product-id": consumer_id,
+            "NHSE-Product-ID": consumer_id,
         },
         params={"includeActions": "Y", "category": "VACCINATIONS", "conditions": "COVID,FLU,RSV"},
         timeout=10,