Skip to content

Commit ec8f74c

Browse files
updated output message
1 parent 62633cd commit ec8f74c

3 files changed

Lines changed: 5 additions & 10 deletions

File tree

src/rules_validation_api/app.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,15 @@
11
import json
2+
import sys
23
from pathlib import Path
34

4-
from pydantic import ValidationError
5-
65
from rules_validation_api.validators.rules_validator import RulesValidation
76

87

98
def main() -> None:
109
with Path.open(Path("campaign_config.json")) as file:
1110
json_data = json.load(file) # this validates json
12-
13-
try:
1411
RulesValidation(**json_data)
15-
print("No validation errors") # noqa: T201
16-
except ValidationError as e:
17-
print(e) # noqa: T201
12+
sys.stdout.write("Valid Config\n")
1813

1914

2015
if __name__ == "__main__":

tests/unit/validation/test_campaign_config_validator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def test_valid_id(self, id_value, valid_campaign_config_with_only_mandatory_fiel
4242
assert model.id == id_value
4343

4444
# Version
45-
@pytest.mark.parametrize("version_value", [1,2,100])
45+
@pytest.mark.parametrize("version_value", [1, 2, 100])
4646
def test_valid_version(self, version_value, valid_campaign_config_with_only_mandatory_fields):
4747
data = {**valid_campaign_config_with_only_mandatory_fields, "Version": version_value}
4848
model = CampaignConfigValidation(**data)
@@ -153,7 +153,7 @@ def test_manager_field(self, manager, valid_campaign_config_with_only_mandatory_
153153
model = CampaignConfigValidation(**data)
154154
assert model.manager == manager
155155

156-
@pytest.mark.parametrize("approver",[["alice"], ["bob"], ["carol"]])
156+
@pytest.mark.parametrize("approver", [["alice"], ["bob"], ["carol"]])
157157
def test_approver_field(self, approver, valid_campaign_config_with_only_mandatory_fields):
158158
data = {**valid_campaign_config_with_only_mandatory_fields, "Approver": approver}
159159
model = CampaignConfigValidation(**data)

tests/unit/validation/test_iteration_validator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def test_valid_id(self, id_value, valid_campaign_config_with_only_mandatory_fiel
4646
assert model.id == id_value
4747

4848
# Version
49-
@pytest.mark.parametrize("version_value", [1,2,100])
49+
@pytest.mark.parametrize("version_value", [1, 2, 100])
5050
def test_valid_version(self, version_value, valid_campaign_config_with_only_mandatory_fields):
5151
data = {**valid_campaign_config_with_only_mandatory_fields["Iterations"][0], "Version": version_value}
5252
model = IterationValidation(**data)

0 commit comments

Comments
 (0)