Skip to content

Commit f891528

Browse files
provided appropriate values factory methods in tests (#245)
1 parent f324e4c commit f891528

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

tests/fixtures/builders/model/eligibility.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,29 @@
55
from polyfactory.factories import DataclassFactory
66

77
from eligibility_signposting_api.model import eligibility
8-
from eligibility_signposting_api.model.eligibility import UrlLink
8+
from eligibility_signposting_api.model.eligibility import RuleType, UrlLink
99

1010

1111
class SuggestedActionFactory(DataclassFactory[eligibility.SuggestedAction]):
1212
url_link = UrlLink("https://test-example.com")
1313

1414

15+
class ReasonFactory(DataclassFactory[eligibility.Reason]):
16+
rule_type = RuleType.filter
17+
18+
19+
class CohortResultFactory(DataclassFactory[eligibility.CohortGroupResult]):
20+
reasons = Use(ReasonFactory.batch, size=2)
21+
22+
1523
class ConditionFactory(DataclassFactory[eligibility.Condition]):
1624
actions = Use(SuggestedActionFactory.batch, size=2)
25+
cohort_results = Use(CohortResultFactory.batch, size=2)
1726

1827

1928
class EligibilityStatusFactory(DataclassFactory[eligibility.EligibilityStatus]):
2029
conditions = Use(ConditionFactory.batch, size=2)
2130

2231

23-
class CohortResultFactory(DataclassFactory[eligibility.CohortGroupResult]): ...
24-
25-
2632
def random_str(length: int) -> str:
2733
return "".join(random.choice(string.ascii_lowercase + string.digits) for _ in range(length))

tests/fixtures/builders/model/rule.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@ class IterationCohortFactory(ModelFactory[rules.IterationCohort]):
2222

2323
class IterationRuleFactory(ModelFactory[rules.IterationRule]):
2424
attribute_target = None
25-
attribute_name = None
25+
attribute_name = "DATE_OF_BIRTH"
26+
operator = "Y>"
27+
comparator = "-1"
2628
cohort_label = None
2729
rule_stop = False
2830

0 commit comments

Comments
 (0)