ELI-674 - new test case for validators

Author: Karthikeyannhs

src/rules_validation_api/app.py

@@ -112,24 +112,22 @@ def display_current_iteration(result: RulesValidation) -> None:
         sorted_iterations = sorted(iterations, key=attrgetter("iteration_date"))
 
         try:
-            next_iteration = next(
-                (i for i in sorted_iterations if i.iteration_date > today), None
-            )
+            next_iteration = next((i for i in sorted_iterations if i.iteration_date > today), None)
 
             if next_iteration:
                 sys.stdout.write(
                     f"{YELLOW}Next active Iteration Number: {RESET}{GREEN}{next_iteration.iteration_number}{RESET}\n"
                 )
                 sys.stdout.write(
-                    f"{YELLOW}Next active Iteration's date&time: {RESET}{GREEN}{next_iteration.iteration_datetime}{RESET}\n"
+                    f"{YELLOW}Next active Iteration's date&time: "
+                    f"{RESET}{GREEN}{next_iteration.iteration_datetime}{RESET}\n"
                 )
         except StopIteration:
             sys.stdout.write(f"{YELLOW}No next active iteration could be determined{RESET}\n")
 
     # ---- Total Iterations ----
-    sys.stdout.write(
-        f"{YELLOW}Total iterations configured: {RESET}{GREEN}{no_of_iterations}{RESET}\n"
-    )
+    sys.stdout.write(f"{YELLOW}Total iterations configured: {RESET}{GREEN}{no_of_iterations}{RESET}\n")
+
 
 if __name__ == "__main__":  # pragma: no cover
     main()

tests/unit/validation/test_app.py

@@ -1,7 +1,7 @@
 import sys
+from datetime import UTC, datetime, timedelta
 from io import StringIO
 from unittest.mock import Mock, PropertyMock
-from datetime import UTC, datetime, timedelta
 
 from pydantic import BaseModel, ValidationError
 
@@ -107,6 +107,7 @@ def test_current_iteration_exists():
     # Arrange
     mock_iteration = Mock()
     mock_iteration.iteration_number = 7
+    mock_iteration.iteration_date = datetime.now(UTC).date() - timedelta(days=1)
 
     result = Mock()
     result.campaign_config = Mock()
@@ -123,5 +124,34 @@ def test_current_iteration_exists():
 
     sys.stdout = sys.__stdout__
 
-    assert "Current Iteration Number:" in captured.getvalue()
+    assert "Current active Iteration Number:" in captured.getvalue()
     assert "7" in captured.getvalue()
+
+
+def test_next_iteration_exists():
+    # Given
+    today = datetime.now(UTC).date()
+
+    # Setup
+    next_mock = Mock()
+    next_mock.iteration_number = 8
+    next_mock.iteration_date = today + timedelta(days=5)
+    next_mock.iteration_datetime = today + timedelta(days=5)
+
+    result = Mock()
+    result.campaign_config.end_date = today + timedelta(days=10)
+    result.campaign_config.iterations = [next_mock]
+    result.campaign_config.campaign_live = False  # To focus only on Next Iteration output
+
+    captured = StringIO()
+    sys.stdout = captured
+
+    # When
+    display_current_iteration(result)
+    sys.stdout = sys.__stdout__
+    output = captured.getvalue()
+
+    # Then
+    assert "Next active Iteration Number:" in output
+    assert "8" in output
+    assert str(today + timedelta(days=5)) in output

tests/unit/validation/test_campaign_config_validator.py

@@ -168,9 +168,7 @@ def test_reviewer_field(self, reviewer, valid_campaign_config_with_only_mandator
         assert model.reviewer == reviewer
 
     @pytest.mark.parametrize("iteration_time", ["14:00:00", "09:30:00", "18:45:00"])
-    def test_iteration_time_field(
-        self, iteration_time, valid_campaign_config_with_only_mandatory_fields
-    ):
+    def test_iteration_time_field(self, iteration_time, valid_campaign_config_with_only_mandatory_fields):
         data = {**valid_campaign_config_with_only_mandatory_fields, "IterationTime": iteration_time}
         model = CampaignConfigValidation(**data)
         assert model.iteration_time == datetime.strptime(iteration_time, "%H:%M:%S").time()  # noqa: DTZ007