From 2cfda02869cb9fd5f8ec70a91fd0bc8d4c63b1c3 Mon Sep 17 00:00:00 2001
From: karthikeyannhs <174426205+Karthikeyannhs@users.noreply.github.com>
Date: Wed, 27 Aug 2025 12:51:14 +0100
Subject: [PATCH 1/2] clean up the dormant PII logs

---
 src/eligibility_signposting_api/repos/person_repo.py     | 3 ---
 .../services/eligibility_services.py                     | 9 ---------
 tests/integration/lambda/test_app_running_as_lambda.py   | 2 +-
 3 files changed, 1 insertion(+), 13 deletions(-)

diff --git a/src/eligibility_signposting_api/repos/person_repo.py b/src/eligibility_signposting_api/repos/person_repo.py
index 2149fab9d..c9f86e9eb 100644
--- a/src/eligibility_signposting_api/repos/person_repo.py
+++ b/src/eligibility_signposting_api/repos/person_repo.py
@@ -38,7 +38,6 @@ def __init__(self, table: Annotated[Any, Inject(qualifier="person_table")]) -> N
 
     def get_eligibility_data(self, nhs_number: NHSNumber) -> Person:
         response = self.table.query(KeyConditionExpression=Key("NHS_NUMBER").eq(nhs_number))
-        logger.debug("response %r for %r", response, nhs_number, extra={"response": response, "nhs_number": nhs_number})
 
         if not (items := response.get("Items")) or not next(
             (item for item in items if item.get("ATTRIBUTE_TYPE") == "PERSON"), None
@@ -46,6 +45,4 @@ def get_eligibility_data(self, nhs_number: NHSNumber) -> Person:
             message = f"Person not found with nhs_number {nhs_number}"
             raise NotFoundError(message)
 
-        logger.debug("returning items %s", items, extra={"items": items})
-
         return Person(data=items)
diff --git a/src/eligibility_signposting_api/services/eligibility_services.py b/src/eligibility_signposting_api/services/eligibility_services.py
index 465f73b08..79934e174 100644
--- a/src/eligibility_signposting_api/services/eligibility_services.py
+++ b/src/eligibility_signposting_api/services/eligibility_services.py
@@ -42,15 +42,6 @@ def get_eligibility_status(
             try:
                 person_data = self.person_repo.get_eligibility_data(nhs_number)
                 campaign_configs = list(self.campaign_repo.get_campaign_configs())
-                logger.debug(
-                    "got person_data for %r",
-                    nhs_number,
-                    extra={
-                        "campaign_configs": [c.model_dump(by_alias=True) for c in campaign_configs],
-                        "person_data": person_data,
-                        "nhs_number": nhs_number,
-                    },
-                )
             except NotFoundError as e:
                 raise UnknownPersonError from e
             else:
diff --git a/tests/integration/lambda/test_app_running_as_lambda.py b/tests/integration/lambda/test_app_running_as_lambda.py
index c54ea08c2..ad3128f9c 100644
--- a/tests/integration/lambda/test_app_running_as_lambda.py
+++ b/tests/integration/lambda/test_app_running_as_lambda.py
@@ -81,7 +81,7 @@ def test_install_and_call_lambda_flask(
         has_entries(statusCode=HTTPStatus.OK, body=is_json_that(has_key("processedSuggestions"))),
     )
 
-    assert_that(log_output, contains_string("person_data"))
+    assert_that(log_output, contains_string(f"checking nhs_number"))
 
 
 def test_install_and_call_flask_lambda_over_http(

From 60b77a5e56989045eb94bbe706be01430b9501ee Mon Sep 17 00:00:00 2001
From: karthikeyannhs <174426205+Karthikeyannhs@users.noreply.github.com>
Date: Wed, 27 Aug 2025 13:55:57 +0100
Subject: [PATCH 2/2] lint fix

---
 tests/integration/lambda/test_app_running_as_lambda.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/integration/lambda/test_app_running_as_lambda.py b/tests/integration/lambda/test_app_running_as_lambda.py
index ad3128f9c..b53ce3812 100644
--- a/tests/integration/lambda/test_app_running_as_lambda.py
+++ b/tests/integration/lambda/test_app_running_as_lambda.py
@@ -81,7 +81,7 @@ def test_install_and_call_lambda_flask(
         has_entries(statusCode=HTTPStatus.OK, body=is_json_that(has_key("processedSuggestions"))),
     )
 
-    assert_that(log_output, contains_string(f"checking nhs_number"))
+    assert_that(log_output, contains_string("checking nhs_number"))
 
 
 def test_install_and_call_flask_lambda_over_http(