Skip to content

Commit 403865d

Browse files
Fix: [AEA-6028] - Fixed boolean env var reading for trailing space
1 parent 29ed377 commit 403865d

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/cdkConstructs/src/config/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export function getConfigFromEnvVar(varName: string, prefix: string = "CDK_CONFI
1111

1212
export function getBooleanConfigFromEnvVar(varName: string, prefix: string = "CDK_CONFIG_"): boolean {
1313
const value = getConfigFromEnvVar(varName, prefix)
14-
return value.toLowerCase() === "true"
14+
return value.toLowerCase().trim() === "true"
1515
}
1616

1717
export function getNumberConfigFromEnvVar(varName: string, prefix: string = "CDK_CONFIG_"): number {

packages/cdkConstructs/tests/config/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ describe("config helpers", () => {
107107
})
108108

109109
test("getBooleanConfigFromEnvVar maps string booleans", () => {
110-
process.env.CDK_CONFIG_FEATURE_FLAG = "true"
111-
process.env.CDK_CONFIG_OTHER_FLAG = "false"
110+
process.env.CDK_CONFIG_FEATURE_FLAG = "true "
111+
process.env.CDK_CONFIG_OTHER_FLAG = " false"
112112

113113
expect(getBooleanConfigFromEnvVar("FEATURE_FLAG")).toBe(true)
114114
expect(getBooleanConfigFromEnvVar("OTHER_FLAG")).toBe(false)

0 commit comments

Comments
 (0)