do not use asdf in tag-release

anthony-nhs · anthony-nhs · commit 0b46f796c73f · 2026-02-18T10:32:01.000Z
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -19,17 +19,13 @@ jobs:
   get_config_values:
     runs-on: ubuntu-22.04
     outputs:
-      asdf_version: ${{ steps.asdf-version.outputs.version }}
       tag_format: ${{ steps.load-config.outputs.TAG_FORMAT }}
       devcontainer_version: ${{ steps.load-config.outputs.DEVCONTAINER_VERSION }}
       devcontainer_image: ${{ steps.load-config.outputs.DEVCONTAINER_IMAGE }}
     steps:
       - name: Checkout code
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
 
-      - name: Get asdf version
-        id: asdf-version
-        run: echo "version=$(awk '!/^#/ && NF {print $1; exit}' .tool-versions.asdf)" >> "$GITHUB_OUTPUT"
       - name: Load config value
         id: load-config
         run: |
@@ -53,7 +49,7 @@ jobs:
     uses: ./.github/workflows/tag-release.yml
     with:
       dry_run: true
-      asdfVersion: ${{ needs.get_config_values.outputs.asdf_version }}
+      runtime_docker_image: "${{ needs.get_config_values.outputs.devcontainer_image }}:githubactions-${{ needs.get_config_values.outputs.devcontainer_version }}"
       branch_name: ${{ github.event.pull_request.head.ref }}
       tag_format: ${{ needs.get_config_values.outputs.tag_format }}
     secrets: inherit
diff --git a/.github/workflows/quality-checks.yml b/.github/workflows/quality-checks.yml
@@ -39,7 +39,6 @@ jobs:
         name: copy .tool-versions
         run: |
           cp /home/vscode/.tool-versions "$HOME/.tool-versions"
-          sudo usermod -aG docker vscode
 
       - &checkout
         name: Checkout code
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,16 +11,12 @@ jobs:
   get_config_values:
     runs-on: ubuntu-22.04
     outputs:
-      asdf_version: ${{ steps.asdf-version.outputs.version }}
       tag_format: ${{ steps.load-config.outputs.TAG_FORMAT }}
       devcontainer_version: ${{ steps.load-config.outputs.DEVCONTAINER_VERSION }}
     steps:
       - name: Checkout code
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
 
-      - name: Get asdf version
-        id: asdf-version
-        run: echo "version=$(awk '!/^#/ && NF {print $1; exit}' .tool-versions.asdf)" >> "$GITHUB_OUTPUT"
       - name: Load config value
         id: load-config
         run: |
@@ -40,7 +36,7 @@ jobs:
     uses: ./.github/workflows/tag-release.yml
     with:
       dry_run: false
-      asdfVersion: ${{ needs.get_config_values.outputs.asdf_version }}
+      runtime_docker_image: "ghcr.io/nhsdigital/eps-devcontainers/node_24_python_3_14:${{ needs.get_config_values.outputs.devcontainer_version }}"
       branch_name: main
       tag_format: ${{ needs.get_config_values.outputs.tag_format }}
     secrets: inherit
diff --git a/.github/workflows/tag-release.yml b/.github/workflows/tag-release.yml
@@ -11,10 +11,9 @@ on:
                 description: "The branch name to base the release on"
                 required: true
                 type: string
-            asdfVersion:
+            runtime_docker_image:
                 type: string
-                required: false
-                default: "0.18.0"
+                required: true
             publish_packages:
                 description: "comma separated list of package folders to publish to an npm registry"
                 required: false
@@ -60,156 +59,43 @@ on:
                 required: false
                 description: "NPM token to publish packages"
 jobs:
-    install_semantic_release:
-        # Install asdf
-        # Use npm install -g to install semantic release and plugins globally
-        ## These are installed in the asdf npm version
-        # Bundle .asdf and upload as artifact
+    tag_release:
         runs-on: ubuntu-22.04
+        container:
+            image: ghcr.io/nhsdigital/eps-devcontainers/${{ inputs.runtime_docker_image }}
+            options: --user 1001:1001 --group-add 128
+        defaults:
+            run:
+                shell: bash
+        outputs:
+            version_tag: ${{steps.output_version_tag.outputs.VERSION_TAG}}
+            change_set_version: ${{ steps.output_change_set_version.outputs.CHANGE_SET_VERSION }}
+            next_version_tag: ${{ steps.output_version_tag.outputs.NEXT_VERSION_TAG }}
         steps:
+            - name: copy .tool-versions
+              run: |
+                  cp /home/vscode/.tool-versions "$HOME/.tool-versions"
             - name: Checkout semantic-release workflow
               uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
               with:
                   repository: NHSDigital/eps-common-workflows
                   sparse-checkout-cone-mode: false
+                  path: eps-common-workflows
                   sparse-checkout: |
                       package.json
                       package-lock.json
                       .tool-versions
                       release.config.cjs
                       releaseNotesTemplates/commit.hbs
-
-            - name: Calculate asdf cache key
-              id: asdf_cache_key
-              run: |
-                  base="${{ runner.os }}-asdf-${{ inputs.asdfVersion }}"
-                  key="$base-${{ hashFiles('**/.tool-versions') }}"
-
-                  echo "base=$base" >> "$GITHUB_OUTPUT"
-                  echo "key=$key" >> "$GITHUB_OUTPUT"
-
-            - name: Calculate installed cache key
-              id: installed_cache_key
-              run: |
-                  base="${{ steps.asdf_cache_key.outputs.key }}-npm"
-                  key="$base-${{ hashFiles('**/package-lock.json') }}"
-
-                  echo "base=$base" >> "$GITHUB_OUTPUT"
-                  echo "key=$key" >> "$GITHUB_OUTPUT"
-
-            - name: Calculate artifact cache key
-              id: artifact_cache_key
-              run: |
-                  base="${{ steps.installed_cache_key.outputs.key }}"
-                  key="$base-artifact"
-
-                  echo "base=$base" >> "$GITHUB_OUTPUT"
-                  echo "key=$key" >> "$GITHUB_OUTPUT"
-
-            - name: Cache asdf artifact
-              id: asdf_artifact_cache
-              uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb
-              with:
-                  path: asdf.tar.gz
-                  key: ${{ steps.artifact_cache_key.outputs.key }}
-                  restore-keys: ${{ steps.artifact_cache_key.outputs.base }}*
-
-            - name: Cache asdf with installed npm packages
-              if: ${{ steps.asdf_artifact_cache.outputs.cache-hit != 'true' }}
-              id: installed_cache
-              uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb
-              with:
-                  path: ~/.asdf
-                  key: ${{ steps.installed_cache_key.outputs.key }}
-                  restore-keys: ${{ steps.installed_cache_key.outputs.base }}*
-
-            - name: Cache asdf
-              if: ${{ steps.installed_cache.outcome == 'success' && steps.installed_cache.outputs.cache-hit != 'true' }}
-              id: asdf_cache
-              uses: actions/cache@9255dc7a253b0ccc959486e2bca901246202afeb
-              with:
-                  path: ~/.asdf
-                  key: ${{ steps.asdf_cache_key.outputs.key }}
-                  restore-keys: |
-                      ${{ steps.asdf_cache_key.outputs.base }}*
-
-            - name: Install asdf dependencies in .tool-versions
-              if: ${{ steps.asdf_cache.outputs.cache-hit == 'false' || steps.asdf_cache.outcome != 'skipped' }}
-              uses: asdf-vm/actions/install@b7bcd026f18772e44fe1026d729e1611cc435d47
-              with:
-                  asdf_version: ${{ inputs.asdfVersion }}
-
             - name: Install semantic release dependencies globally
-              if: ${{ steps.installed_cache.outputs.cache-hit == 'false' || steps.installed_cache.outcome != 'skipped' }}
               run: |
+                  cd eps-common-workflows
                   dependencies="$(jq -r '.devDependencies | to_entries | map("\(.key)@\(.value)") | join(" ")' package.json)"
                   echo "Installing: $dependencies"
 
                   # shellcheck disable=SC2086
                   npm install --global $dependencies
 
-            - name: Prepare asdf artifact
-              if: ${{ steps.asdf_artifact_cache.outputs.cache-hit != 'true' }}
-              run: |
-                  tar -czf asdf.tar.gz -C "$HOME" .asdf
-
-            - name: Upload asdf artifact
-              uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
-              with:
-                  name: asdf_artifact
-                  path: asdf.tar.gz
-                  overwrite: true
-
-            - name: Prepare config artifact
-              run: |
-                  mkdir -p config_artifact/releaseNotesTemplates
-                  cp release.config.cjs config_artifact/
-                  cp releaseNotesTemplates/commit.hbs config_artifact/releaseNotesTemplates/
-
-            - name: Upload config artifact
-              uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f
-              with:
-                  name: config_artifact
-                  path: config_artifact/
-                  overwrite: true
-
-    tag_release:
-        needs: install_semantic_release
-        runs-on: ubuntu-22.04
-        outputs:
-            version_tag: ${{steps.output_version_tag.outputs.VERSION_TAG}}
-            change_set_version: ${{ steps.output_change_set_version.outputs.CHANGE_SET_VERSION }}
-            next_version_tag: ${{ steps.output_version_tag.outputs.NEXT_VERSION_TAG }}
-        steps:
-            - name: Fetch asdf artifact
-              uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
-              with:
-                  name: asdf_artifact
-            - name: Install asdf
-              uses: asdf-vm/actions/setup@b7bcd026f18772e44fe1026d729e1611cc435d47
-              with:
-                  asdf_version: ${{ inputs.asdfVersion }}
-
-            - name: Extract asdf
-              run: tar -xzf asdf.tar.gz -C "$HOME"
-
-            - name: Setup node from cache
-              run: |
-                  # Get installed node version (trim whitespace with xargs)
-                  NODE_VER=$(asdf list nodejs | head -n1 | xargs)
-                  NODE_DIR="$HOME/.asdf/installs/nodejs/$NODE_VER"
-
-                  echo "Using Node $NODE_VER from cache at $NODE_DIR"
-                  asdf set -u nodejs "$NODE_VER"
-
-                  # Prepend binaries to path
-                  echo "$NODE_DIR/bin" >> "$GITHUB_PATH"
-                  echo "$NODE_DIR/lib/node_modules/.bin" >> "$GITHUB_PATH"
-
-                  # # Set node path to resolve packages
-                  # NODE_PATH="$NODE_DIR/lib/node_modules"
-                  # echo "NODE_PATH=$NODE_PATH" >> $GITHUB_ENV
-
             - name: Clone calling repo
               uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
               with:
@@ -225,29 +111,6 @@ jobs:
               env:
                   BRANCH_NAME: ${{ inputs.branch_name }}
 
-            - name: Fetch semantic-release config
-              uses: actions/download-artifact@37930b1c2abaa49bbe596cd826c3c89aef350131
-              with:
-                  name: config_artifact
-
-            - name: Cache asdf
-              if: inputs.publish_packages != ''
-              uses: actions/cache@v5
-              with:
-                  path: |
-                      ~/.asdf
-                  key: ${{ runner.os }}-asdf-${{ hashFiles('**/.tool-versions') }}
-                  restore-keys: |
-                      ${{ runner.os }}-asdf-
-
-            - name: Install asdf dependencies in .tool-versions
-              if: inputs.publish_packages != ''
-              uses: asdf-vm/actions/install@b7bcd026f18772e44fe1026d729e1611cc435d47
-              with:
-                  asdf_version: ${{ inputs.asdfVersion }}
-              env:
-                  PYTHON_CONFIGURE_OPTS: --enable-shared
-
             - name: Install Dependencies and Build Package
               if: inputs.publish_packages != ''
               run: |
@@ -262,6 +125,11 @@ jobs:
                   github-token: ${{ secrets.GITHUB_TOKEN }}
                   repository: ${{ inputs.extra_artifact_repository }}
                   run-id: ${{ inputs.extra_artifact_run_id }}
+            - name: Copy semantic release config
+              run: |
+                  cp eps-common-workflows/release.config.cjs .
+                  mkdir -p releaseNotesTemplates
+                  cp eps-common-workflows/releaseNotesTemplates/commit.hbs releaseNotesTemplates/
 
             - name: Set VERSION_TAG based on dry_run flag
               id: output_version_tag
