update

Author: anthony-nhs

.github/prompts/code_review.prompt.md

@@ -0,0 +1,59 @@
+---
+description: "Perform a comprehensive code review"
+---
+
+## Role
+
+You're a senior software engineer conducting a thorough code review. Provide constructive, actionable feedback.
+
+## Review Areas
+
+Analyze the selected code for:
+
+1. **Security Issues**
+   - Input validation and sanitization
+   - Authentication and authorization
+   - Data exposure risks
+   - Injection vulnerabilities
+
+2. **Performance & Efficiency**
+   - Algorithm complexity
+   - Memory usage patterns
+   - Database query optimization
+   - Unnecessary computations
+
+3. **Code Quality**
+   - Readability and maintainability
+   - Proper naming conventions
+   - Function/class size and responsibility
+   - Code duplication
+
+4. **Architecture & Design**
+   - Design pattern usage
+   - Separation of concerns
+   - Dependency management
+   - Error handling strategy
+
+5. **Testing & Documentation**
+   - Test coverage and quality
+   - Documentation completeness
+   - Comment clarity and necessity
+
+## Output Format
+
+Provide feedback as:
+
+**🔴 Critical Issues** - Must fix before merge
+**🟡 Suggestions** - Improvements to consider
+**✅ Good Practices** - What's done well
+
+For each issue:
+
+- Specific line references
+- Clear explanation of the problem
+- Suggested solution with code example
+- Rationale for the change
+
+Focus on: ${input:focus:Any specific areas to emphasize in the review?}
+
+Be constructive and educational in your feedback.

.github/workflows/sync_copilot.yml

@@ -3,13 +3,13 @@ name: Sync copilot instructions
 on:
   workflow_call:
     inputs:
-      ref:
-        description: "The branch to sync from the central repository"
+      common_workflows_ref:
+        description: "The ref to sync from the central repository"
         required: false
         default: "main"
         type: string
-      base_branch:
-        description: "The base branch for the pull request"
+      calling_repo_base_branch:
+        description: "The base branch from the calling repository for"
         required: false
         type: string
         default: main
@@ -30,22 +30,30 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
         with:
-          ref: ${{ env.BRANCH_NAME }}
+          ref: ${{ inputs.calling_repo_base_branch }}
           fetch-depth: 0
 
-      - name: Fetch central instructions
+      - name: Checkout code
+        uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
+        with:
+          ref: ${{ inputs.common_workflows_ref }}
+          fetch-depth: 0
+          path: eps-common-workflows
+          repository: NHSDigital/eps-common-workflows
+          sparse-checkout: |
+            - .github/instructions
+            - .github/copilot-instructions.md
+            - .github/chatmodes
+            - .github/prompts
+
+      - name: Copy central instructions
         run: |
-          rm -rf .github/copilot
-          git clone \
-            --depth 1 \
-            --branch "${BRANCH_NAME}" \
-            https://github.com/NHSDigital/eps-common-workflows.git tmp
-          mv tmp/.github/chatmodes .github/chatmodes
-          mv tmp/.github/instructions .github/instructions
-          mv tmp/.github/copilot-instructions.md .github/copilot-instructions.md
-          rm -rf tmp
-        env:
-          BRANCH_NAME: ${{ inputs.ref }}
+          mv eps-common-workflows/.github/chatmodes .github/chatmodes
+          mv eps-common-workflows/.github/instructions .github/instructions
+          mv eps-common-workflows/.github/copilot-instructions.md .github/copilot-instructions.md
+          mv eps-common-workflows/.github/prompts .github/prompts
+          rm -rf eps-common-workflows
+
       - name: Create GitHub App Token
         uses: actions/create-github-app-token@f8d387b68d61c58ab83c6c016672934102569859
         id: generate-token
@@ -61,9 +69,9 @@ jobs:
           title: "Upgrade: [dependabot] - sync Copilot instructions"
           body: |
             Syncing Copilot instructions from central repo.
-            Ref: `${{ inputs.ref }}`
+            Ref: `${{ inputs.common_workflows_ref }}`
           branch: copilot-instructions-sync
-          base: ${{ inputs.base_branch }}
+          base: ${{ inputs.calling_repo_base_branch }}
           branch-suffix: random
           sign-commits: true
           delete-branch: true

README.md

@@ -8,6 +8,7 @@ The workflows that are available to use are
 
 - [Combine Dependabot PRs](#combine-dependabot-prs)
 - [Dependabot Auto Approve and Merge](#dependabot-auto-approve-and-merge)
+- [Sync copilot instructios](#sync-copilot-instructions)
 - [PR Title Check](#pr-title-check)
 - [Get Repo Config](#get-repo-config)
 - [Quality Checks](#quality-checks)
@@ -114,8 +115,8 @@ This workflow syncs Copilot instructions from this repo into another repo and op
 
 #### Inputs
 
-- `ref`: Branch in this repo to sync from. Default: `main`
-- `base_branch`: Target branch for the pull request. Default: `main`.
+- `common_workflows_ref`: Branch in common workflows repo to sync from. Default: `main`
+- `base_branch`: The base branch in the calling repository. Default: `main`.
 
 #### Secret Inputs
 
@@ -130,21 +131,21 @@ name: Sync Copilot Instructions
 on:
   workflow_dispatch:
     inputs:
-      ref:
+      common_workflows_ref:
         description: "Branch to sync from"
         required: false
         type: string
+        default: main
 
 jobs:
   sync-copilot:
     uses: NHSDigital/eps-common-workflows/.github/workflows/sync_copilot.yml@f5c8313a10855d0cc911db6a9cd666494c00045a
     with:
-      ref: ${{ github.event.inputs.ref }}
+      ref: ${{ github.event.inputs.common_workflows_ref }}
     secrets:
       CREATE_PULL_REQUEST_APP_ID: ${{ secrets.CREATE_PULL_REQUEST_APP_ID }}
       CREATE_PULL_REQUEST_PEM: ${{ secrets.CREATE_PULL_REQUEST_PEM }}
 ```
-```
 ## PR Title Check
 This workflow checks that all pull requests have a title that matches the required format, and comments on the PR with a link to the relevant ticket if a ticket reference is found.