Skip to content

Commit bc651ab

Browse files
committed
run new checks
1 parent ef03469 commit bc651ab

2 files changed

Lines changed: 12 additions & 57 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@
66
"args": {
77
"DOCKER_GID": "${env:DOCKER_GID:}",
88
"IMAGE_NAME": "node_24_python_3_14",
9+
<<<<<<< Updated upstream
910
"IMAGE_VERSION": "pr-68-7f136dd",
11+
=======
12+
"IMAGE_VERSION": "pr-69-0337303",
13+
>>>>>>> Stashed changes
1014
"USER_UID": "${localEnv:USER_ID:}",
1115
"USER_GID": "${localEnv:GROUP_ID:}"
1216
},

.github/workflows/quality-checks-devcontainer.yml

Lines changed: 8 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,7 @@ jobs:
122122
fi
123123
- name: Check licenses
124124
run: |
125-
make trivy-license-check
126-
127-
- name: Show license scan output
128-
if: always()
129-
run: |
130-
if [ -f license_scan.txt ]; then
131-
cat .trivy_out/license_scan.txt
132-
fi
125+
make grant-scan
133126
- name: Run code lint
134127
run: |
135128
make lint
@@ -141,51 +134,19 @@ jobs:
141134
- name: Run unit tests
142135
run: |
143136
make test
144-
- name: make generate sbom
137+
- name: Generate sbom
145138
run: |
146-
make trivy-generate-sbom
139+
make syft-generate-sbom-dev-dependencies
147140
- name: Upload sbom
148141
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f
149142
with:
150-
name: sbom.cdx.json
151-
path: .trivy_out/sbom.cdx.json
143+
name: sbom.dev.cdx.json
144+
path: .sbom/sbom.dev.cdx.json
152145

153-
- name: Check python vulnerabilities
154-
if: ${{ steps.check_languages.outputs.uses_poetry == 'true' }}
155-
continue-on-error: ${{ github.actor == 'dependabot[bot]' }}
146+
- name: Check vulnerabilities
156147
run: |
157-
make trivy-scan-python
148+
make grype-scan-dev-dependencies
158149
159-
- name: Check node vulnerabilities
160-
if: ${{ steps.check_languages.outputs.uses_node == 'true' }}
161-
continue-on-error: ${{ github.actor == 'dependabot[bot]' }}
162-
run: |
163-
make trivy-scan-node
164-
- name: Check go vulnerabilities
165-
if: ${{ steps.check_languages.outputs.uses_go == 'true' }}
166-
continue-on-error: ${{ github.actor == 'dependabot[bot]' }}
167-
run: |
168-
make trivy-scan-go
169-
- name: Check java vulnerabilities
170-
if: ${{ steps.check_languages.outputs.uses_java == 'true' }}
171-
continue-on-error: ${{ github.actor == 'dependabot[bot]' }}
172-
run: |
173-
make trivy-scan-java
174-
- name: Show vulnerability output
175-
if: always()
176-
run: |
177-
if [ -f .trivy_out/dependency_results_python.txt ]; then
178-
cat .trivy_out/dependency_results_python.txt
179-
fi
180-
if [ -f .trivy_out/dependency_results_node.txt ]; then
181-
cat .trivy_out/dependency_results_node.txt
182-
fi
183-
if [ -f .trivy_out/dependency_results_java.txt ]; then
184-
cat .trivy_out/dependency_results_java.txt
185-
fi
186-
if [ -f .trivy_out/dependency_results_go.txt ]; then
187-
cat .trivy_out/dependency_results_go.txt
188-
fi
189150
- name: "check is SONAR_TOKEN exists"
190151
env:
191152
super_secret: ${{ secrets.SONAR_TOKEN }}
@@ -311,17 +272,7 @@ jobs:
311272
- name: Check docker vulnerabilities
312273
continue-on-error: ${{ github.actor == 'dependabot[bot]' }}
313274
run: |
314-
make trivy-scan-docker
315-
env:
316-
DOCKER_IMAGE: ${{ matrix.docker_image }}
317-
318-
- name: Show docker vulnerability output
319-
if: always()
320-
run: |
321-
echo "Scan output for ${DOCKER_IMAGE}"
322-
if [ -f .trivy_out/dependency_results_docker.txt ]; then
323-
cat .trivy_out/dependency_results_docker.txt
324-
fi
275+
make grype-scan-docker-image
325276
env:
326277
DOCKER_IMAGE: ${{ matrix.docker_image }}
327278

0 commit comments

Comments
 (0)