Skip to content

Commit c4efd04

Browse files
authored
Chore: [AEA-0000] - remove gitsecrets (#145)
## Summary - Routine Change ### Details - remove gitsecrets setup
1 parent ba4bcd7 commit c4efd04

1 file changed

Lines changed: 10 additions & 7 deletions

File tree

.github/workflows/quality-checks-devcontainer.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ on:
1818
required: false
1919
docker_images:
2020
type: string
21-
description: comma separated list of docker image references to scan when docker scanning is enabled.
21+
description: comma separated list of docker image references to scan when docker
22+
scanning is enabled.
2223
default: ""
2324
required: false
2425
pinned_image:
@@ -42,7 +43,8 @@ jobs:
4243
shell: bash
4344
steps:
4445
- &init_tool_versions
45-
name: copy needed files from devcontainer user to runner home directory or bin directory
46+
name: copy needed files from devcontainer user to runner home directory or bin
47+
directory
4648
run: |
4749
cp /home/vscode/.tool-versions "$HOME/.tool-versions"
4850
cp /home/vscode/.grant.yaml "$HOME/.grant.yaml"
@@ -80,8 +82,6 @@ jobs:
8082
make install
8183
- name: Run secrets scan
8284
run: |
83-
git-secrets --register-aws
84-
git-secrets --add-provider -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt
8585
make secret-scan
8686
- name: Run actionlint
8787
run: |
@@ -172,7 +172,8 @@ jobs:
172172
run: echo "SONAR_TOKEN_EXISTS=true" >> "$GITHUB_ENV"
173173

174174
- name: Run SonarQube analysis
175-
if: ${{ steps.check_languages.outputs.uses_java == 'true' && env.SONAR_TOKEN_EXISTS == 'true' }}
175+
if: ${{ steps.check_languages.outputs.uses_java == 'true' &&
176+
env.SONAR_TOKEN_EXISTS == 'true' }}
176177
run: |
177178
# issues with sonar scanner and sslcontext-kickstart 9.1.0, forcing re-download
178179
rm -rf ~/.m2/repository/io/github/hakky54/sslcontext-kickstart/9.1.0
@@ -184,7 +185,8 @@ jobs:
184185

185186
- name: SonarCloud Scan
186187
uses: SonarSource/sonarqube-scan-action@299e4b793aaa83bf2aba7c9c14bedbb485688ec4
187-
if: ${{ steps.check_languages.outputs.uses_java == 'false' && env.SONAR_TOKEN_EXISTS == 'true' }}
188+
if: ${{ steps.check_languages.outputs.uses_java == 'false' &&
189+
env.SONAR_TOKEN_EXISTS == 'true' }}
188190
env:
189191
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
190192
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
@@ -364,7 +366,8 @@ jobs:
364366
fi
365367
366368
- name: Run cfn-lint
367-
if: steps.check_sam_templates.outputs.sam_exists == 'true' || steps.check_cf_templates.outputs.cf_exists == 'true'
369+
if: steps.check_sam_templates.outputs.sam_exists == 'true' ||
370+
steps.check_cf_templates.outputs.cf_exists == 'true'
368371
run: |
369372
make cfn-lint
370373

0 commit comments

Comments
 (0)