Skip to content

Commit fd59b52

Browse files
committed
update following feedback
1 parent 493637f commit fd59b52

4 files changed

Lines changed: 24 additions & 18 deletions

File tree

.github/copilot-instructions.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ Check the following files for any project-specific coding standards or guideline
1111
Always follow security best practices as outlined in:
1212
- .github/instructions/general/security.instructions.md
1313
Follow additional language-specific guidelines in:
14-
- .github/instructions/language-specific/cdk.instructions.md
15-
- .github/instructions/language-specific/cloudformation.instructions.md
16-
- .github/instructions/language-specific/python.instructions.md
17-
- .github/instructions/language-specific/terraform.instructions.md
18-
- .github/instructions/language-specific/sam.instructions.md
19-
- .github/instructions/language-specific/typescript.instructions.md
14+
- .github/instructions/languages/cdk.instructions.md
15+
- .github/instructions/languages/cloudformation.instructions.md
16+
- .github/instructions/languages/python.instructions.md
17+
- .github/instructions/languages/terraform.instructions.md
18+
- .github/instructions/languages/sam.instructions.md
19+
- .github/instructions/languages/typescript.instructions.md
2020

2121
## Project-Specific Rules
2222
- Use our custom logging service

.github/instructions/general/security.instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
applyTo: '*/*'
2+
applyTo: '**/*'
33
description: "Comprehensive secure coding instructions for all languages and frameworks, based on OWASP Top 10 and industry best practices."
44
---
55
# Secure Coding and OWASP Guidelines

.github/workflows/sync_copilot.yml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
default: "main"
1010
type: string
1111
calling_repo_base_branch:
12-
description: "The base branch from the calling repository for"
12+
description: "The base branch from the calling repository that should be merged into"
1313
required: false
1414
type: string
1515
default: main
@@ -21,7 +21,7 @@ on:
2121

2222
jobs:
2323
sync:
24-
runs-on: ubuntu-latest
24+
runs-on: ubuntu-22.04
2525
permissions:
2626
contents: write
2727
pull-requests: write
@@ -41,16 +41,22 @@ jobs:
4141
path: eps-common-workflows
4242
repository: NHSDigital/eps-common-workflows
4343
sparse-checkout: |
44-
- .github/instructions/general
45-
- .github/instructions/languages
46-
- .github/copilot-instructions.md
47-
- .github/prompts
44+
.github/instructions/general
45+
.github/instructions/languages
46+
.github/copilot-instructions.md
47+
.github/prompts
4848
4949
- name: Copy central instructions
5050
run: |
51-
mv eps-common-workflows/.github/instructions .github/instructions
52-
mv eps-common-workflows/.github/copilot-instructions.md .github/copilot-instructions.md
53-
mv eps-common-workflows/.github/prompts .github/prompts
51+
rm -rf .github/instructions/general
52+
rm -rf .github/instructions/languages
53+
rm -rf .github/copilot-instructions.md
54+
rm -rf .github/prompts
55+
mkdir -p .github/instructions/
56+
cp -R eps-common-workflows/.github/instructions/general .github/instructions/general
57+
cp -R eps-common-workflows/.github/instructions/languages .github/instructions/languages
58+
cp eps-common-workflows/.github/copilot-instructions.md .github/copilot-instructions.md
59+
cp -R eps-common-workflows/.github/prompts .github/prompts
5460
rm -rf eps-common-workflows
5561
5662
- name: Create GitHub App Token

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ The workflows that are available to use are
88

99
- [Combine Dependabot PRs](#combine-dependabot-prs)
1010
- [Dependabot Auto Approve and Merge](#dependabot-auto-approve-and-merge)
11-
- [Sync copilot instructios](#sync-copilot-instructions)
11+
- [Sync copilot instructions](#sync-copilot-instructions)
1212
- [PR Title Check](#pr-title-check)
1313
- [Get Repo Config](#get-repo-config)
1414
- [Quality Checks](#quality-checks)
@@ -116,7 +116,7 @@ This workflow syncs Copilot instructions from this repo into another repo and op
116116
#### Inputs
117117
118118
- `common_workflows_ref`: Branch in common workflows repo to sync from. Default: `main`
119-
- `base_branch`: The base branch in the calling repository. Default: `main`.
119+
- `calling_repo_base_branch`: The base branch in the calling repository. Default: `main`.
120120

121121
#### Secret Inputs
122122

0 commit comments

Comments
 (0)