Skip to content

Commit 3daa482

Browse files
committed
fix some issues
1 parent 7b1afeb commit 3daa482

5 files changed

Lines changed: 3 additions & 5 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66
"args": {
77
"DOCKER_GID": "${env:DOCKER_GID:}",
88
"IMAGE_NAME": "node_24_python_3_14",
9-
"IMAGE_VERSION": "v1.2.0",
9+
"IMAGE_VERSION": "v1.3.0",
1010
"USER_UID": "${localEnv:USER_ID:}",
1111
"USER_GID": "${localEnv:GROUP_ID:}"
1212
},
1313
"updateRemoteUserUID": false
1414
},
15-
"postAttachCommand": "git-secrets --register-aws; git-secrets --add-provider -- cat /usr/share/secrets-scanner/nhsd-rules-deny.txt",
1615
"mounts": [
1716
"source=${env:HOME}${env:USERPROFILE}/.aws,target=/home/vscode/.aws,type=bind",
1817
"source=${env:HOME}${env:USERPROFILE}/.ssh,target=/home/vscode/.ssh,type=bind",

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,3 @@ jobs:
2929
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
3030
branch_name: main
3131
tag_format: ${{ needs.get_config_values.outputs.tag_format }}
32-
secrets: inherit

.github/workflows/pull_request.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,3 @@ jobs:
3838
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
3939
branch_name: ${{ github.event.pull_request.head.ref }}
4040
tag_format: ${{ needs.get_config_values.outputs.tag_format }}
41-
secrets: inherit

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,3 @@ jobs:
3030
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
3131
branch_name: main
3232
tag_format: ${{ needs.get_config_values.outputs.tag_format }}
33-
secrets: inherit

action.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ runs:
2323
with:
2424
ref: ${{ inputs.calling_repo_base_branch }}
2525
fetch-depth: 0
26+
persist-credentials: false
2627

2728
- name: Checkout central repo code
2829
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
@@ -31,6 +32,7 @@ runs:
3132
fetch-depth: 0
3233
path: eps-copilot-instructions
3334
repository: NHSDigital/eps-copilot-instructions
35+
persist-credentials: false
3436
sparse-checkout: |
3537
.github/instructions/general
3638
.github/instructions/languages

0 commit comments

Comments
 (0)