Skip to content

Commit 02983ff

Browse files
committed
fix(gsul): better func name
1 parent c47c9a2 commit 02983ff

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/gsul/src/getStatusUpdates.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const lambdaHandler = async (event: requestType): Promise<responseType> => {
2727
// this is an async map so it returns an array of promises
2828
const itemResults = event.prescriptions.map(async (prescription) => {
2929
const queryResult = await getItemsUpdatesForPrescription(prescription.prescriptionID, prescription.odsCode, logger)
30-
return filterOutPostDatedUpdates(prescription, queryResult)
30+
return filterOutFutureReduceToLatestUpdates(prescription, queryResult)
3131
})
3232

3333
// wait for all the promises to complete
@@ -40,7 +40,7 @@ const lambdaHandler = async (event: requestType): Promise<responseType> => {
4040
return response
4141
}
4242

43-
export const filterOutPostDatedUpdates = (
43+
export const filterOutFutureReduceToLatestUpdates = (
4444
inputPrescription: inputPrescriptionType,
4545
items: Array<itemType>,
4646
currentTime: number = Date.now() // injectable for testing

packages/gsul/tests/testBuildResult.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {filterOutPostDatedUpdates} from "../src/getStatusUpdates"
1+
import {filterOutFutureReduceToLatestUpdates} from "../src/getStatusUpdates"
22
import {inputPrescriptionType} from "../src/schema/request"
33
import {outputPrescriptionType, itemType} from "../src/schema/response"
44

@@ -207,7 +207,7 @@ describe("Unit tests for buildResults", () => {
207207
it.each<scenariosType>(scenarios)("$scenarioDescription", ({inputPrescriptions, queryResults, expectedResult}) => {
208208
// Use a fixed time of 2000-01-01 for tests (946684800000 ms since epoch)
209209
const fixedCurrentTime = new Date("2000-01-01T00:00:00Z").getTime()
210-
const result = filterOutPostDatedUpdates(inputPrescriptions, queryResults, fixedCurrentTime)
210+
const result = filterOutFutureReduceToLatestUpdates(inputPrescriptions, queryResults, fixedCurrentTime)
211211
expect(result).toMatchObject(expectedResult)
212212
})
213213
})

0 commit comments

Comments
 (0)